Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentValidationFailureCode from integration test. #2253

Closed
chilagrow opened this issue Mar 22, 2023 · 0 comments · Fixed by #3002
Closed

Remove documentValidationFailureCode from integration test. #2253

chilagrow opened this issue Mar 22, 2023 · 0 comments · Fixed by #3002
Assignees
Labels
code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Milestone

Comments

@chilagrow
Copy link
Contributor

What should be done?

documentValidationFailureCode is used to skip tigris test in compat test. We want to remove this. But this might not be simple.

For example, an operator that update the value like bson.D{{"$set", bson.D{{"v", int32(42)}}}} would pass on Int32s provider on tigris but fail on all other providers, because tigris schema won't be the right one for other ones.
We need to think of a setup to only run tigris test on specific provider. It kind of feels like we may need to set tigris schema per test case.

Where?

documentValidationFailureCode

Definition of Done

  • integration/compatibility tests added/updated;
  • spot refactorings done;
@chilagrow chilagrow added the code/chore Code maintenance improvements label Mar 22, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 1, 2023
@AlekSi AlekSi mentioned this issue Jul 6, 2023
9 tasks
@AlekSi AlekSi added this to the Next milestone Jul 6, 2023
@AlekSi AlekSi self-assigned this Jul 6, 2023
AlekSi added a commit that referenced this issue Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants