Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support maxTimeMS in getMore command parameter #2984

Closed
Tracked by #75
chilagrow opened this issue Jul 5, 2023 · 0 comments · Fixed by #3917 or #3919
Closed
Tracked by #75

Support maxTimeMS in getMore command parameter #2984

chilagrow opened this issue Jul 5, 2023 · 0 comments · Fixed by #3917 or #3919
Assignees
@noisersup
Labels
area/cursors Issues about cursors area/oplog Issues about OpLog and capped collections code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI
Milestone
v1.19.0

Comments

@chilagrow
Copy link
Contributor

chilagrow commented Jul 5, 2023 •
edited by AlekSi

What should be done?

After #2283

https://www.mongodb.com/docs/manual/reference/command/getMore/

maxTimeMS for getMore is supported only for tailable cursor.

Where?

https://github.com/FerretDB/FerretDB/blob/main/internal/handlers/common/getmore.go

Definition of Done

  • all handlers updated;
  • integration/compatibility tests added/updated;
  • spot refactorings done;
  • user documentation updated or an issue to create documentation created;
@chilagrow chilagrow added code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 5, 2023
@chilagrow chilagrow mentioned this issue Jul 5, 2023
Closed
@AlekSi AlekSi added the area/cursors Issues about cursors label Jul 10, 2023
@AlekSi AlekSi mentioned this issue Oct 5, 2023
Closed
@AlekSi AlekSi added the area/oplog Issues about OpLog and capped collections label Oct 5, 2023
@b1ron b1ron mentioned this issue Oct 31, 2023
Open
@AlekSi AlekSi added this to the Next milestone Dec 18, 2023
@AlekSi AlekSi assigned noisersup and unassigned ferretdb-bot Dec 28, 2023
This was referenced Jan 1, 2024
Merged
Merged
Closed
@AlekSi AlekSi reopened this Jan 4, 2024
@AlekSi AlekSi modified the milestones: v1.18.0, Next Jan 8, 2024
@AlekSi AlekSi mentioned this issue Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisersup noisersup

Labels
area/cursors Issues about cursors area/oplog Issues about OpLog and capped collections code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Current Engineering
Archived in project
Milestone
v1.19.0
4 participants
@AlekSi @chilagrow @noisersup @ferretdb-bot