-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow maxTimeMS
for non-awaitData cursors in getMore
command
#3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3917 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 330 330
Lines 25722 25734 +12
=======================================
+ Hits 19038 19047 +9
- Misses 5556 5557 +1
- Partials 1128 1130 +2
... and 7 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
commented
Jan 1, 2024
noisersup
changed the title
Support
Disallow Jan 1, 2024
maxTimeMS
in getMore
commandmaxTimeMS
for non-awaitData cursors in getMore
command
noisersup
changed the title
Disallow
Disallow Jan 1, 2024
maxTimeMS
for non-awaitData cursors in getMore
commandmaxTimeMS
for non-awaitData cursors in getMore
command
rumyantseva
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
henvic
approved these changes
Jan 2, 2024
AlekSi
added
not ready
Issues that are not ready to be worked on; PRs that should skip CI
and removed
not ready
Issues that are not ready to be worked on; PRs that should skip CI
labels
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2984.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.