Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow maxTimeMS for non-awaitData cursors in getMore command #3917

Merged
merged 17 commits into from Jan 4, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jan 1, 2024

Description

Closes #2984.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a17ca1) 74.01% compared to head (a7adac5) 74.01%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3917   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         330      330           
  Lines       25722    25734   +12     
=======================================
+ Hits        19038    19047    +9     
- Misses       5556     5557    +1     
- Partials     1128     1130    +2     
Files Coverage Δ
internal/handler/msg_getmore.go 85.00% <100.00%> (+0.72%) ⬆️

... and 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.61% <100.00%> (+<0.01%) ⬆️
hana-1 ?
integration 70.61% <100.00%> (+<0.01%) ⬆️
mongodb-1 5.21% <0.00%> (-0.01%) ⬇️
postgresql-1 51.23% <41.66%> (+1.16%) ⬆️
postgresql-2 50.33% <100.00%> (-0.71%) ⬇️
postgresql-3 51.48% <41.66%> (-0.33%) ⬇️
sqlite-1 50.38% <41.66%> (+1.22%) ⬆️
sqlite-2 49.38% <100.00%> (-0.86%) ⬇️
sqlite-3 50.56% <41.66%> (-0.39%) ⬇️
unit 30.95% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title Support maxTimeMS in getMore command Disallow maxTimeMS for non-awaitData cursors in getMore command Jan 1, 2024
@noisersup noisersup marked this pull request as ready for review January 1, 2024 19:02
@noisersup noisersup requested a review from a team as a code owner January 1, 2024 19:02
@noisersup noisersup added the code/enhancement Some user-visible feature could work better label Jan 1, 2024
@noisersup noisersup added this to the Next milestone Jan 1, 2024
@noisersup noisersup enabled auto-merge (squash) January 1, 2024 19:03
@noisersup noisersup changed the title Disallow maxTimeMS for non-awaitData cursors in getMore command Disallow maxTimeMS for non-awaitData cursors in getMore command Jan 1, 2024
@noisersup noisersup requested review from b1ron, a team and henvic January 1, 2024 19:05
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration/cursors/getmore_test.go Show resolved Hide resolved
internal/handler/msg_getmore.go Show resolved Hide resolved
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jan 4, 2024
@noisersup noisersup merged commit ca5677d into FerretDB:main Jan 4, 2024
28 checks passed
@noisersup noisersup deleted the maxtimems-2984 branch January 4, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support maxTimeMS in getMore command parameter
4 participants