Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run scheduled CI on combinations of -disable-filter-pushdown and -enable-sort-pushdown flags #3126

Closed
chilagrow opened this issue Jul 27, 2023 · 0 comments · Fixed by #3407
Closed

Run scheduled CI on combinations of -disable-filter-pushdown and -enable-sort-pushdown flags #3126

chilagrow opened this issue Jul 27, 2023 · 0 comments · Fixed by #3407
Assignees
@AlekSi
Labels
area/pushdown Issues about query pushdown code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Milestone
v1.11.0

Comments

@chilagrow
Copy link
Contributor

chilagrow commented Jul 27, 2023 •
edited
Loading

What should be done?

At the moment we run CI with default pushdown option of -disable-filter-pushdown=false -enable-sort-pushdown=false.

We should schedule CI with other combination of flags like below to run periodically, maybe once a day, at least before the release.
-disable-filter-pushdown=true -enable-sort-pushdown=true
-disable-filter-pushdown=true -enable-sort-pushdown=false
-disable-filter-pushdown=false -enable-sort-pushdown=true

Where?

https://github.com/FerretDB/FerretDB/blob/main/.github/workflows/go.yml
https://github.com/FerretDB/FerretDB/blob/main/Taskfile.yml

Definition of Done

  • scheduled CI runs on github
@chilagrow chilagrow added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 27, 2023
@AlekSi AlekSi added the area/pushdown Issues about query pushdown label Sep 20, 2023
AlekSi added a commit to AlekSi/FerretDB that referenced this issue Sep 20, 2023
@AlekSi
Add CI configuration for SQLite without pushdown
8b378d4 
Refs FerretDB#3126.
@AlekSi AlekSi mentioned this issue Sep 20, 2023
Merged
9 tasks
@AlekSi AlekSi assigned AlekSi and unassigned ferretdb-bot Sep 21, 2023
@AlekSi AlekSi added this to the Next milestone Sep 21, 2023
@AlekSi AlekSi mentioned this issue Sep 21, 2023
Merged
9 tasks
AlekSi added a commit that referenced this issue Sep 22, 2023
@AlekSi
Run new PostgreSQL backend tests (#3407)
d976d8c 
Closes #3126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekSi AlekSi

Labels
area/pushdown Issues about query pushdown code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

Run new PostgreSQL backend tests AlekSi/FerretDB
3 participants
@AlekSi @chilagrow @ferretdb-bot