Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLite unstable tests #3172

Closed
Tracked by #3069
noisersup opened this issue Aug 8, 2023 · 1 comment · Fixed by #3195 or #3222
Closed
Tracked by #3069

Fix SQLite unstable tests #3172

noisersup opened this issue Aug 8, 2023 · 1 comment · Fixed by #3195 or #3222
Assignees
Labels
backend/sqlite Issues about SQLite backend code/chore Code maintenance improvements
Milestone

Comments

@noisersup
Copy link
Member

noisersup commented Aug 8, 2023

What should be done?

It seems that some tests from basic_tests.go are still unstable. Every test/subtest pass correctly if ran alone, although if we try to run more of them, there are SQL logic error: no such table: _ferretdb_collections (1) errors.

Some results of investigation here: #3169

Simple stress test that reproduce it: #3195.

Where?

  • basic_tests.go
  • query_test.go
  • update_array_compat_test.go
  • update_field_compat_test.go
  • update_field_test.go
  • SQLite backend

Definition of Done

  • all handlers updated;
  • unit tests added/updated;
  • integration/compatibility tests added/updated;
  • spot refactorings done;
  • user documentation updated or an issue to create documentation created;
  • something else?
@noisersup noisersup added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 8, 2023
@chilagrow
Copy link
Contributor

I can reproduce this locally by running below

$ task test-integration-sqlite TEST_RUN='BenchmarkInsertMany|TestAggregateAddFieldsErrors|TestAggregateCommandMaxTimeMSErrors|TestAggregateCompatCount|TestAggregateCompatGroupCount|TestAggregateCompatGroupExpressionDottedFieldsDocs|TestAggregateCompatMatch|TestAggregateCompatProject|TestAggregateCompatSkip|TestAggregateCompatStages|TestAggregateGroupErrors|TestAggregateSetErrors|TestAggregateVariablesCompatRoot|TestCommandWhatsMyURIConnection|TestCommandsAdministrationCollStats|TestCommandsAdministrationCompatCollStatsWithScale|TestCommandsAdministrationCreateDropListDatabases|TestCommandsAdministrationDBStatsEmpty|TestCommandsAdministrationDataSize|TestCommandsAdministrationKillCursors|TestCommandsAdministrationServerStatus|TestCommandsAdministrationServerStatusStress|TestCommandsAuthenticationSASLStart|TestCommandsDiagnosticGetLog|TestCommandsDiagnosticValidate|TestCommandsFreeMonitoringGetFreeMonitoringStatus|TestCountCommandCompatErrors|TestCreateIndexesCommandCompat|TestCreateIndexesCommandInvalidSpec|TestCreateNestedDocument|TestCreateStress|TestDebugError|TestDeleteCommandCompatNotExistingDatabase|TestDeleteCompat|TestDistinctCommandErrors|TestDotNotation|TestDropIndexesCommandInvalidCollection|TestEmptyKey|TestFindAndModifyCommandErrors|TestFindAndModifyCommentQuery|TestFindAndModifyCompatRemove|TestFindAndModifyCompatUnset|TestFindAndModifyCompatUpdateRename|TestFindAndModifyCompatUpsertSet|TestFindAndModifyNonExistingCollection|TestFindNothing|TestGetMoreCommandConnection|TestGetParameterCommandAuthenticationMechanisms|TestInsertCompat|TestMostCommandsAreCaseSensitive|TestQueryArrayCompatDotNotation|TestQueryArrayCompatSize|TestQueryBitwiseAllClear|TestQueryBitwiseAnySet|TestQueryCommandLimitPushDown|TestQueryComparisonCompatGt|TestQueryComparisonCompatIn|TestQueryComparisonCompatMultipleOperators|TestQueryCompatBatchSize|TestQueryCompatSkip|TestQueryElementCompatElementType'

@AlekSi AlekSi assigned noisersup and unassigned ferretdb-bot Aug 14, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 14, 2023
@AlekSi AlekSi added the backend/sqlite Issues about SQLite backend label Aug 16, 2023
@AlekSi AlekSi self-assigned this Aug 17, 2023
AlekSi added a commit that referenced this issue Aug 17, 2023
Closes #3172.

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
@AlekSi AlekSi reopened this Aug 17, 2023
AlekSi added a commit to AlekSi/FerretDB that referenced this issue Aug 17, 2023
@AlekSi AlekSi added this to the Next milestone Aug 17, 2023
AlekSi added a commit that referenced this issue Aug 17, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this issue Aug 31, 2023
Closes FerretDB#3172.

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
yonarw pushed a commit to yonarw/FerretDB that referenced this issue Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/sqlite Issues about SQLite backend code/chore Code maintenance improvements
Projects
Archived in project
5 participants