Process --run and --skip in the envtool itself

[AlekSi]

What should be done?

Currently, when envtool tests run is invoked with --run and/or --skip flags, we just pass those values to go test's -run and -skip, skip tests listing and sharding. That makes the output less useful: there is no known number of total tests, the progress indicator is worse, etc.

Let's get a list of tests as usual, then apply --run and --skip's regular expressions ourselves, then shard the resulting list.

Where?

FerretDB/cmd/envtool/tests.go

Lines 356 to 398 in 1e736b9

	// testsRun runs tests specified by the shard index and total or by the run regex
	// using `go test` with given extra args.
	func testsRun(ctx context.Context, index, total uint, run, skip string, args []string, logger *zap.SugaredLogger) error {
	logger.Debugf("testsRun: index=%d, total=%d, run=%q, args=%q", index, total, run, args)
	var totalTest int
	if run == "" {
	if index == 0 || total == 0 {
	return fmt.Errorf("--shard-index and --shard-total must be specified when --run is not")
	}
	all, err := listTestFuncs("")
	if err != nil {
	return lazyerrors.Error(err)
	}
	shard, err := shardTestFuncs(index, total, all)
	if err != nil {
	return lazyerrors.Error(err)
	}
	run = "^("
	for i, t := range shard {
	run += t
	if i != len(shard)-1 {
	run += "|"
	}
	}
	totalTest = len(shard)
	run += ")$"
	}
	if skip != "" {
	totalTest = 0
	args = append(args, "-run="+run, "-skip="+skip)
	} else {
	args = append(args, "-run="+run)
	}
	return runGoTest(ctx, args, totalTest, true, logger)
	}

Definition of Done

• envtool code updated;
• envtool's unit tests added/updated;
• spot refactorings done.

[fadyat]

@korzio Hi, I see we have a conflict here 😢
I've done everything, you can chill

[korzio]

@fadyat ah I see thx. Well, next time for me than 😢

[AlekSi]

That's exactly why we ask contributors to leave a comment on the issue before starting working on it (https://github.com/FerretDB/FerretDB/blob/main/CONTRIBUTING.md#finding-something-to-work-on)

[AlekSi]

#4101 (review) Anyway, not important right now.