Fix envtool run test -run and -skip flags
#4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4101 +/- ##
==========================================
- Coverage 76.22% 75.07% -1.16%
==========================================
Files 349 349
Lines 22170 22170
==========================================
- Hits 16899 16644 -255
- Misses 3960 4258 +298
+ Partials 1311 1268 -43 see 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
reviewed
Feb 21, 2024
AlekSi
reviewed
Feb 21, 2024
rumyantseva
previously approved these changes
Feb 23, 2024
|
@henvic this pull request has merge conflicts. |
AlekSi
reviewed
Feb 27, 2024
| shard, err := shardTestFuncs(index, total, all) | ||
| // Then, shard all the tests but only run the ones that match the regex and that should | ||
| // be run on the specific shard. | ||
| shard, skipShard, err := shardTestFuncs(index, total, tests) |
There was a problem hiding this comment.
Note that shard's content is not actually used
| } | ||
|
|
||
| if skip != "" { | ||
| args = append(args, "-skip="+skip) |
There was a problem hiding this comment.
I don't understand what we are doing there. #3969's title is "Process --run and --skip in the envtool itself". Somehow, we both process those flags ourselves, then ignore the result for the --run processing, but pass -skip.
What I think we should do is what the issue says. In more detail:
- get
--runand--skipvalues; - get a list of all tests;
- filter that list by applying
--runand--skipvalues; - run those tests by invoking
go test -run– without-skipbecause we already process--skip's regular expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic for filtering the tests should be applied before sharding and use the same logic as the Go standard testing library.
Closes #3969.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.