Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tjson: Implement datetime #1027

Merged
merged 16 commits into from
Aug 12, 2022
Merged

tjson: Implement datetime #1027

merged 16 commits into from
Aug 12, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 11, 2022

Description

This PR closes #905.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added code/feature Some user-visible feature is not implemented yet code/tigris labels Aug 11, 2022
@noisersup noisersup self-assigned this Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1027 (50083e5) into main (e6a4e8f) will decrease coverage by 0.06%.
The diff coverage is 67.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   63.87%   63.81%   -0.07%     
==========================================
  Files         238      239       +1     
  Lines       11179    11211      +32     
==========================================
+ Hits         7141     7154      +13     
- Misses       3206     3221      +15     
- Partials      832      836       +4     
Impacted Files Coverage Δ
internal/tjson/datetime.go 56.00% <56.00%> (ø)
internal/tjson/tjson.go 70.06% <88.88%> (+1.72%) ⬆️
integration/shareddata/shareddata.go 82.53% <100.00%> (ø)
internal/tjson/schema.go 69.60% <100.00%> (+2.13%) ⬆️
internal/clientconn/conninfo/conn_info.go 66.66% <0.00%> (-16.67%) ⬇️
internal/handlers/pg/msg_dbstats.go 65.11% <0.00%> (-6.98%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/settings.go 39.53% <0.00%> (-4.66%) ⬇️
internal/handlers/common/filter.go 85.38% <0.00%> (ø)
... and 1 more
Flag Coverage Δ
integration 59.35% <59.45%> (-0.09%) ⬇️
mongodb 18.06% <100.00%> (-0.02%) ⬇️
pg 61.99% <100.00%> (-0.13%) ⬇️
tigris 26.75% <59.45%> (+0.23%) ⬆️
unit 24.25% <62.85%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review August 12, 2022 11:31
@noisersup noisersup requested a review from a team as a code owner August 12, 2022 11:31
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Aug 12, 2022
@AlekSi AlekSi added this to the v0.6.0 milestone Aug 12, 2022
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

internal/tjson/datetime.go Outdated Show resolved Hide resolved
internal/tjson/datetime.go Show resolved Hide resolved
internal/tjson/datetime.go Outdated Show resolved Hide resolved
internal/tjson/datetime.go Outdated Show resolved Hide resolved
@noisersup noisersup requested review from AlekSi and a team and removed request for a team August 12, 2022 15:07
@AlekSi AlekSi enabled auto-merge (squash) August 12, 2022 15:10
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit c8f6b78 into FerretDB:main Aug 12, 2022
@noisersup noisersup deleted the tjson-datetime-905 branch August 12, 2022 15:23
@noisersup noisersup mentioned this pull request Aug 17, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tjson: Implement datetime
3 participants