Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic metrics. #108

Merged
merged 3 commits into from
Dec 5, 2021
Merged

Add basic metrics. #108

merged 3 commits into from
Dec 5, 2021

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 2, 2021 •
edited
Loading

Refs #74.

Response statuses are not done yet. Adding them requires listener/conn/handler refactoring that should be in a separate PR.

@AlekSi AlekSi marked this pull request as ready for review December 4, 2021 14:03
@AlekSi AlekSi requested a review from OpenSauce December 4, 2021 14:04
OpenSauce
OpenSauce approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@OpenSauce OpenSauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Not on my home pc at the moment though。

@AlekSi AlekSi merged commit d2a03c0 into main Dec 5, 2021
@AlekSi AlekSi deleted the metrics branch December 5, 2021 17:05
@AlekSi AlekSi added this to the v0.0.5 milestone Dec 6, 2021
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenSauce OpenSauce OpenSauce approved these changes

Assignees
No one assigned
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.0.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlekSi @OpenSauce