Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement simple query pushdown for Tigris #1091

Merged
merged 12 commits into from
Sep 1, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 28, 2022

Description

This PR closes #897.

Only _id with ObjectID and string values for now.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Aug 28, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #1091 (627fddd) into main (84c5a89) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   65.81%   65.90%   +0.08%     
==========================================
  Files         248      248              
  Lines       11853    11875      +22     
==========================================
+ Hits         7801     7826      +25     
+ Misses       3187     3182       -5     
- Partials      865      867       +2     
Impacted Files Coverage Δ
integration/shareddata/shareddata.go 83.07% <100.00%> (+0.26%) ⬆️
internal/handlers/tigris/msg_delete.go 69.13% <100.00%> (ø)
internal/handlers/tigris/msg_find.go 55.26% <100.00%> (+0.79%) ⬆️
internal/handlers/tigris/tigrisdb/query.go 78.94% <100.00%> (+10.52%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 85.38% <0.00%> (ø)
internal/handlers/pg/pgdb/settings.go 44.18% <0.00%> (+4.65%) ⬆️
Flag Coverage Δ
integration 62.11% <100.00%> (+0.09%) ⬆️
mongodb 15.20% <4.00%> (-3.24%) ⬇️
pg 52.64% <4.00%> (-11.11%) ⬇️
tigris 32.16% <100.00%> (+0.14%) ⬆️
unit 24.47% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Aug 31, 2022
@AlekSi AlekSi marked this pull request as ready for review August 31, 2022 11:46
@AlekSi AlekSi requested a review from a team as a code owner August 31, 2022 11:46
@AlekSi AlekSi requested review from rumyantseva, a team, w84thesun and noisersup and removed request for a team August 31, 2022 11:46
@AlekSi AlekSi enabled auto-merge (squash) August 31, 2022 11:47
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a small suggestion for the queryDocumentsFilter method.

internal/handlers/tigris/tigrisdb/query.go Outdated Show resolved Hide resolved
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you checked (maybe manually) that we really go to the database :)

LGTM overall.

@AlekSi AlekSi merged commit edad1f8 into FerretDB:main Sep 1, 2022
@AlekSi AlekSi deleted the tigris-pushdown branch September 1, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support simple query pushdown for Tigris
4 participants