-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Tigris test cases with explicit schemas #1167
Setup Tigris test cases with explicit schemas #1167
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 66.38% 66.33% -0.06%
==========================================
Files 250 251 +1
Lines 12256 12293 +37
==========================================
+ Hits 8136 8154 +18
- Misses 3232 3248 +16
- Partials 888 891 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
…om/rumyantseva/FerretDB into tigris-setup-tests-with-validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM,
I pointed one more place where we should declare the variable in place of initialization
…om/rumyantseva/FerretDB into tigris-setup-tests-with-validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Refs #906. As we support JSON Schema validators for Tigris, in tests let's create collections by defining them explicitly.
This PR is preparation for #1005.
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.