Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzz wire package with recorded data #1168

Merged
merged 22 commits into from Sep 26, 2022
Merged

Fuzz wire package with recorded data #1168

merged 22 commits into from Sep 26, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Sep 21, 2022 •
edited

Description

This PR closes #1140.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Sep 21, 2022
@vercel
Copy link

vercel bot commented Sep 21, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 5:46PM (UTC)

@noisersup noisersup added the code/chore Code maintenance improvements label Sep 21, 2022
@vercel vercel bot temporarily deployed to Preview September 21, 2022 23:34 Inactive
@vercel vercel bot temporarily deployed to Preview September 22, 2022 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview September 22, 2022 00:41 Inactive
@vercel vercel bot temporarily deployed to Preview September 22, 2022 13:26 Inactive
@noisersup
Copy link
Member Author

noisersup commented Sep 22, 2022 •
edited

Should these tests be placed in seperate file like here, or I didn't catch something in the issue?

@AlekSi AlekSi self-requested a review September 23, 2022 08:07
AlekSi
AlekSi reviewed Sep 23, 2022
View reviewed changes
internal/wire/records_test.go Outdated Show resolved Hide resolved
internal/wire/records_test.go Outdated Show resolved Hide resolved
internal/wire/records_test.go Outdated Show resolved Hide resolved
internal/wire/records_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 23, 2022 12:59 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2022 13:07 Inactive
@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited

Codecov Report

Merging #1168 (f5a085f) into main (fb6600a) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   66.19%   66.13%   -0.06%     
==========================================
  Files         250      250              
  Lines       12249    12249              
==========================================
- Hits         8108     8101       -7     
- Misses       3249     3254       +5     
- Partials      892      894       +2
Impacted Files Coverage Δ
internal/handlers/tigris/msg_listdatabases.go 45.07% <0.00%> (-5.64%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.01% <0.00%> (ø)
Flag Coverage Δ
integration 62.42% <ø> (-0.06%) ⬇️
mongodb 14.79% <ø> (-0.01%) ⬇️
pg 51.87% <ø> (-0.03%) ⬇️
tigris 34.42% <ø> (-0.06%) ⬇️
unit 23.97% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview September 23, 2022 13:27 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2022 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2022 14:17 Inactive
@vercel vercel bot temporarily deployed to Preview September 23, 2022 14:34 Inactive
@vercel vercel bot temporarily deployed to Preview September 26, 2022 10:43 Inactive
AlekSi
AlekSi requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked all done items in this checklist.

Please do that

AlekSi
AlekSi requested changes Sep 26, 2022
View reviewed changes
internal/wire/records_test.go Show resolved Hide resolved
internal/wire/records_test.go Outdated Show resolved Hide resolved
internal/wire/wire_test.go Outdated Show resolved Hide resolved
internal/wire/wire_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 26, 2022 11:32 Inactive
@vercel vercel bot temporarily deployed to Preview September 26, 2022 11:34 Inactive
w84thesun
w84thesun suggested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, small changes needed.

internal/wire/records_test.go Show resolved Hide resolved
internal/wire/records_test.go Outdated Show resolved Hide resolved
@noisersup
Update internal/wire/records_test.go
c962401 
Co-authored-by: Dmitry <dmitry.eremenko@ferretdb.io>
@vercel vercel bot temporarily deployed to Preview September 26, 2022 15:42 Inactive
AlekSi
AlekSi reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few stye suggestions

internal/wire/wire_test.go Outdated Show resolved Hide resolved
internal/wire/wire_test.go Outdated Show resolved Hide resolved
internal/wire/records_test.go Show resolved Hide resolved
internal/wire/records_test.go Outdated Show resolved Hide resolved
internal/wire/records_test.go Show resolved Hide resolved
noisersup and others added 2 commits September 26, 2022 19:05
@noisersup @AlekSi
Update internal/wire/wire_test.go
016585c 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@noisersup @AlekSi
Update internal/wire/wire_test.go
26eb8e0 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@vercel vercel bot temporarily deployed to Preview September 26, 2022 17:07 Inactive
@vercel vercel bot temporarily deployed to Preview September 26, 2022 17:28 Inactive
@vercel vercel bot temporarily deployed to Preview September 26, 2022 17:46 Inactive
AlekSi
AlekSi approved these changes Sep 26, 2022
View reviewed changes
internal/wire/records_test.go Show resolved Hide resolved
w84thesun
w84thesun approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi enabled auto-merge (squash) September 26, 2022 18:24
@AlekSi AlekSi merged commit 9798110 into FerretDB:main Sep 26, 2022
@noisersup noisersup deleted the fuzz-with-records-1140 branch September 26, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fuzz wire package with recorded data
3 participants
@noisersup @AlekSi @w84thesun