Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tigris auth parameters #1177

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Add support for Tigris auth parameters #1177

merged 4 commits into from
Sep 26, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 23, 2022

Description

Those parameters are needed for the cloud version of Tigris.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 6:28PM (UTC)

@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Sep 23, 2022
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Sep 23, 2022
@AlekSi AlekSi self-assigned this Sep 23, 2022
@vercel vercel bot temporarily deployed to Preview September 23, 2022 10:49 Inactive
@AlekSi AlekSi changed the title Add support for additional Tigris parameters Add support for Tigris auth parameters Sep 23, 2022
@AlekSi AlekSi marked this pull request as ready for review September 23, 2022 10:53
@AlekSi AlekSi requested a review from a team as a code owner September 23, 2022 10:53
@AlekSi AlekSi requested review from w84thesun, rumyantseva, a team and noisersup and removed request for a team September 23, 2022 10:53
@AlekSi AlekSi enabled auto-merge (squash) September 23, 2022 10:53
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1177 (cf0925a) into main (9798110) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files         250      250           
  Lines       12249    12260   +11     
=======================================
+ Hits         8104     8112    +8     
- Misses       3252     3254    +2     
- Partials      893      894    +1     
Impacted Files Coverage Δ
internal/handlers/registry/registry.go 36.66% <ø> (ø)
ferretdb/ferretdb.go 93.75% <100.00%> (+0.72%) ⬆️
internal/handlers/registry/tigris.go 100.00% <100.00%> (ø)
internal/handlers/tigris/tigris.go 76.19% <100.00%> (+3.96%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.01% <0.00%> (ø)
Flag Coverage Δ
integration 62.45% <100.00%> (+<0.01%) ⬆️
mongodb 14.80% <47.05%> (+<0.01%) ⬆️
pg 51.86% <47.05%> (-0.04%) ⬇️
tigris 34.44% <52.94%> (-0.01%) ⬇️
unit 23.99% <47.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok, but maybe we can add more docs somewhere? (E.g. some links where to read about those params as Tigris is quite a specific thing)

noisersup
noisersup previously approved these changes Sep 26, 2022
@vercel vercel bot temporarily deployed to Preview September 26, 2022 10:25 Inactive
@AlekSi
Copy link
Member Author

AlekSi commented Sep 26, 2022

@rumyantseva I added comments for our embedded usage, PTAL

@vercel vercel bot temporarily deployed to Preview September 26, 2022 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview September 26, 2022 18:28 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit ed68ca2 into FerretDB:main Sep 26, 2022
@AlekSi AlekSi deleted the tigris branch September 26, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants