-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Tigris auth parameters #1177
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 250 250
Lines 12249 12260 +11
=======================================
+ Hits 8104 8112 +8
- Misses 3252 3254 +2
- Partials 893 894 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks ok, but maybe we can add more docs somewhere? (E.g. some links where to read about those params as Tigris is quite a specific thing)
@rumyantseva I added comments for our embedded usage, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Those parameters are needed for the cloud version of Tigris.
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.