Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old validation #1179

Merged
merged 40 commits into from Oct 12, 2022
Merged

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Sep 26, 2022

Description

This PR refs #693.
In this part, we remove all the validation to add it from scratch 🤓
I will send another PR that adds the correct validation back.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/enhancement Some user-visible feature could work better label Sep 26, 2022
@rumyantseva rumyantseva self-assigned this Sep 26, 2022
@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 6:58AM (UTC)

@vercel vercel bot temporarily deployed to Preview September 26, 2022 09:25 Inactive
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1179 (e8a77f1) into main (8ab516d) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   66.58%   66.29%   -0.30%     
==========================================
  Files         268      268              
  Lines       12974    12881      -93     
==========================================
- Hits         8639     8539     -100     
- Misses       3390     3395       +5     
- Partials      945      947       +2     
Impacted Files Coverage Δ
internal/types/array.go 85.10% <ø> (+1.29%) ⬆️
internal/types/types.go 77.35% <ø> (-8.53%) ⬇️
internal/util/testutil/equal.go 51.59% <ø> (ø)
internal/wire/op_query.go 32.14% <ø> (ø)
internal/types/document.go 87.34% <100.00%> (+2.16%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/bson/document.go 44.02% <0.00%> (-3.08%) ⬇️
internal/wire/op_msg.go 48.35% <0.00%> (-1.41%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (-0.63%) ⬇️
Flag Coverage Δ
integration 61.06% <100.00%> (+0.02%) ⬆️
mongodb 13.80% <50.00%> (-0.27%) ⬇️
pg 50.83% <100.00%> (-0.02%) ⬇️
tigris 32.98% <50.00%> (-0.10%) ⬇️
unit 25.70% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview September 26, 2022 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview September 28, 2022 08:55 Inactive
@rumyantseva rumyantseva changed the title Add basic validation for queries. Add basic validation for queries Sep 28, 2022
@vercel vercel bot temporarily deployed to Preview September 28, 2022 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview September 28, 2022 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview September 29, 2022 07:48 Inactive
@vercel vercel bot temporarily deployed to Preview October 6, 2022 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 08:25 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 13:12 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 16:11 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 16:15 Inactive
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 10, 2022
@vercel vercel bot temporarily deployed to Preview October 10, 2022 18:09 Inactive
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test still fails

@vercel vercel bot temporarily deployed to Preview October 11, 2022 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 08:59 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 12:29 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 18:16 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 18:23 Inactive
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva enabled auto-merge (squash) October 11, 2022 18:34
@vercel vercel bot temporarily deployed to Preview October 12, 2022 06:58 Inactive
@rumyantseva rumyantseva merged commit feb0ee6 into FerretDB:main Oct 12, 2022
@rumyantseva rumyantseva deleted the issue-693-validation branch October 12, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly disallow field names with $
4 participants