Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY known differences documentation #1181

Merged
merged 3 commits into from Sep 26, 2022
Merged

DRY known differences documentation #1181

merged 3 commits into from Sep 26, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 26, 2022

Description

Three places were too much.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label Sep 26, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Sep 26, 2022
@AlekSi AlekSi self-assigned this Sep 26, 2022
@AlekSi AlekSi requested review from a team and Fashander September 26, 2022 17:31
@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 6:53PM (UTC)

@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva and noisersup and removed request for a team September 26, 2022 17:31
@AlekSi AlekSi enabled auto-merge (squash) September 26, 2022 17:31
@vercel vercel bot temporarily deployed to Preview September 26, 2022 17:32 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of facts, thought I think there is room for @Fashander to help with some language-related things ;)

@vercel vercel bot temporarily deployed to Preview September 26, 2022 18:27 Inactive
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1181 (ab73fc0) into main (a55d3a7) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1181      +/-   ##
==========================================
- Coverage   66.22%   66.16%   -0.06%     
==========================================
  Files         250      250              
  Lines       12260    12260              
==========================================
- Hits         8119     8112       -7     
- Misses       3249     3254       +5     
- Partials      892      894       +2     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/query.go 40.68% <0.00%> (-2.76%) ⬇️
internal/handlers/common/filter.go 86.01% <0.00%> (ø)
Flag Coverage Δ
integration 62.45% <ø> (-0.03%) ⬇️
mongodb 14.80% <ø> (-0.03%) ⬇️
pg 51.86% <ø> (-0.03%) ⬇️
tigris 34.44% <ø> (-0.03%) ⬇️
unit 23.67% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview September 26, 2022 18:53 Inactive
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 9c1e684 into FerretDB:main Sep 26, 2022
@AlekSi AlekSi deleted the diff-docs branch September 26, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants