Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluky test, refactor it #1185

Merged
merged 1 commit into from Sep 27, 2022
Merged

Fix fluky test, refactor it #1185

merged 1 commit into from Sep 27, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 27, 2022

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 27, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Sep 27, 2022
@AlekSi AlekSi self-assigned this Sep 27, 2022
@AlekSi AlekSi requested a review from a team as a code owner September 27, 2022 11:21
@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 11:23AM (UTC)

@AlekSi AlekSi requested review from a team and noisersup and removed request for a team September 27, 2022 11:21
@AlekSi AlekSi enabled auto-merge (squash) September 27, 2022 11:22
@vercel vercel bot temporarily deployed to Preview September 27, 2022 11:23 Inactive
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1185 (145b602) into main (cdcf9b6) will increase coverage by 21.22%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1185       +/-   ##
===========================================
+ Coverage   44.94%   66.16%   +21.22%     
===========================================
  Files         250      250               
  Lines       12260    12260               
===========================================
+ Hits         5510     8112     +2602     
+ Misses       6042     3254     -2788     
- Partials      708      894      +186     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/clientconn/conn.go 44.52% <0.00%> (+0.70%) ⬆️
integration/helpers.go 87.23% <0.00%> (+1.06%) ⬆️
internal/handlers/pg/pgdb/collections.go 50.00% <0.00%> (+2.27%) ⬆️
internal/handlers/pg/pgdb/settings.go 39.53% <0.00%> (+2.32%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
internal/handlers/pg/pgdb/query.go 40.68% <0.00%> (+4.82%) ⬆️
internal/handlers/pg/pgdb/databases.go 55.00% <0.00%> (+5.00%) ⬆️
internal/types/document.go 86.69% <0.00%> (+8.25%) ⬆️
internal/handlers/common/limit.go 75.00% <0.00%> (+8.33%) ⬆️
... and 48 more
Flag Coverage Δ
integration 62.45% <ø> (+25.46%) ⬆️
mongodb 14.80% <ø> (-0.03%) ⬇️
pg 51.86% <ø> (?)
tigris 34.44% <ø> (-0.03%) ⬇️
unit 23.87% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've checkouted to the branch and there are still TestFindAndModifyCompatErrors that are failing locally, but I assume that's not the scope of this PR

@AlekSi AlekSi merged commit bc00013 into FerretDB:main Sep 27, 2022
@AlekSi AlekSi deleted the tigris-test branch September 27, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants