Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate envtool to Kong #1190

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Migrate envtool to Kong #1190

merged 4 commits into from
Sep 28, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Sep 28, 2022 •
edited
Loading

Description

This PR is a part of #1156.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Sep 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 1:27PM (UTC)

@noisersup noisersup self-assigned this Sep 28, 2022
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Sep 28, 2022
@noisersup noisersup linked an issue Sep 28, 2022 that may be closed by this pull request
Migrate FerretDB and envtool to Kong #1156
Closed
2 tasks
@vercel vercel bot temporarily deployed to Preview September 28, 2022 11:28 Inactive
@noisersup noisersup mentioned this pull request Sep 28, 2022
Closed
2 tasks
@codecov
Copy link

codecov bot commented Sep 28, 2022 •
edited
Loading

Codecov Report

Merging #1190 (f5cfb8a) into main (91186e7) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f5cfb8a differs from pull request most recent head 879a784. Consider uploading reports for the commit 879a784 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
- Coverage   66.35%   66.33%   -0.03%     
==========================================
  Files         251      251              
  Lines       12293    12293              
==========================================
- Hits         8157     8154       -3     
- Misses       3246     3248       +2     
- Partials      890      891       +1
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (ø)
Flag Coverage Δ
integration 62.62% <ø> (-0.03%) ⬇️
mongodb 14.87% <ø> (-0.03%) ⬇️
pg 51.86% <ø> (-0.03%) ⬇️
tigris 34.67% <ø> (-0.03%) ⬇️
unit 24.00% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview September 28, 2022 11:59 Inactive
@noisersup noisersup requested review from a team, AlekSi, w84thesun and rumyantseva and removed request for a team September 28, 2022 12:32
@noisersup noisersup marked this pull request as ready for review September 28, 2022 12:32
rumyantseva
rumyantseva previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

cmd/envtool/main.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 28, 2022 13:19 Inactive
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Sep 28, 2022
@AlekSi
Copy link
Member

AlekSi commented Sep 28, 2022

(envtool is an internal tool, so that's chore; FerretDB binary flags are user-visible, so PR for that would be a feature)

@noisersup @rumyantseva
Update cmd/envtool/main.go
879a784 
Co-authored-by: Elena Grahovac <elena@grahovac.me>
AlekSi
AlekSi requested changes Sep 28, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked all done items in this checklist.

That item is unchecked, so I assume that wasn't done

@noisersup
Copy link
Member Author

@AlekSi Sorry, it's marked now

@vercel vercel bot temporarily deployed to Preview September 28, 2022 13:27 Inactive
rumyantseva
rumyantseva approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi enabled auto-merge (squash) September 28, 2022 13:33
@AlekSi AlekSi merged commit e919083 into FerretDB:main Sep 28, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.

Migrate FerretDB and envtool to Kong
3 participants
@noisersup @AlekSi @rumyantseva