Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pgdb SQL statements #1193

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Cleanup pgdb SQL statements #1193

merged 2 commits into from
Sep 29, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Sep 29, 2022

Description

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 3:57PM (UTC)

@w84thesun w84thesun self-assigned this Sep 29, 2022
@w84thesun w84thesun added the code/chore Code maintenance improvements label Sep 29, 2022
@w84thesun w84thesun added this to the v0.6.0 Alpha milestone Sep 29, 2022
@vercel vercel bot temporarily deployed to Preview September 29, 2022 10:40 Inactive
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1193 (14e304c) into main (fb31975) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
- Coverage   66.35%   66.33%   -0.03%     
==========================================
  Files         251      251              
  Lines       12293    12293              
==========================================
- Hits         8157     8154       -3     
- Misses       3246     3248       +2     
- Partials      890      891       +1     
Impacted Files Coverage Δ
integration/setup/setup.go 87.25% <ø> (ø)
integration/setup/setup_compat.go 88.39% <ø> (ø)
internal/handlers/pg/pgdb/settings.go 39.53% <100.00%> (ø)
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (ø)
Flag Coverage Δ
integration 62.62% <100.00%> (-0.03%) ⬇️
mongodb 14.89% <0.00%> (-0.01%) ⬇️
pg 51.86% <100.00%> (-0.03%) ⬇️
tigris 34.67% <0.00%> (-0.03%) ⬇️
unit 24.00% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun requested review from a team, AlekSi, rumyantseva and noisersup and removed request for a team September 29, 2022 11:14
@w84thesun w84thesun marked this pull request as ready for review September 29, 2022 11:14
@w84thesun w84thesun requested a review from a team as a code owner September 29, 2022 11:14
@AlekSi AlekSi enabled auto-merge (squash) September 29, 2022 15:55
@vercel vercel bot temporarily deployed to Preview September 29, 2022 15:57 Inactive
@AlekSi AlekSi merged commit ae2d498 into FerretDB:main Sep 29, 2022
@w84thesun w84thesun deleted the cleanup-pgdb branch October 3, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants