Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UUID to log messages #1208

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Add UUID to log messages #1208

merged 7 commits into from
Oct 11, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 4, 2022 •
edited
Loading

Description

Refs #1209.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Oct 4, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 4, 2022
@AlekSi AlekSi self-assigned this Oct 4, 2022
@vercel
Copy link

vercel bot commented Oct 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 6:15PM (UTC)

@vercel vercel bot temporarily deployed to Preview October 4, 2022 14:44 Inactive
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #1208 (635db65) into main (51eeb82) will increase coverage by 20.36%.
The diff coverage is 81.60%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1208       +/-   ##
===========================================
+ Coverage   46.15%   66.51%   +20.36%     
===========================================
  Files         267      268        +1     
  Lines       12926    12974       +48     
===========================================
+ Hits         5966     8630     +2664     
+ Misses       6201     3396     -2805     
- Partials      759      948      +189
Impacted Files Coverage Δ
internal/util/logging/buffer.go 87.23% <ø> (ø)
internal/clientconn/conn.go 44.01% <16.66%> (+0.39%) ⬆️
internal/util/state/state.go 79.54% <79.54%> (ø)
internal/util/logging/logging.go 81.25% <93.75%> (-5.71%) ⬇️
ferretdb/ferretdb.go 88.00% <100.00%> (ø)
integration/setup/common.go 93.22% <100.00%> (ø)
internal/clientconn/listener.go 76.28% <100.00%> (ø)
internal/handlers/pg/msg_getlog.go 76.66% <100.00%> (+76.66%) ⬆️
internal/handlers/tigris/msg_getlog.go 75.58% <100.00%> (ø)
internal/clientconn/conninfo/conn_info.go 66.66% <0.00%> (-16.67%) ⬇️
... and 60 more
Flag Coverage Δ
integration 60.96% <83.72%> (+25.47%) ⬆️
mongodb 14.04% <79.06%> (-0.04%) ⬇️
pg 50.78% <81.39%> (?)
tigris 33.05% <81.39%> (-0.05%) ⬇️
unit 26.25% <76.74%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Add state directory with UUID Add UUID to metrics Oct 4, 2022
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/feature Some user-visible feature is not implemented yet labels Oct 4, 2022
@vercel vercel bot temporarily deployed to Preview October 5, 2022 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview October 6, 2022 07:54 Inactive
@AlekSi AlekSi added the do not merge PRs that should not be merged label Oct 10, 2022
@vercel vercel bot temporarily deployed to Preview October 10, 2022 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 15:13 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 15:16 Inactive
@vercel vercel bot temporarily deployed to Preview October 10, 2022 17:48 Inactive
@AlekSi AlekSi changed the title Add UUID to metrics Add UUID to log messages Oct 11, 2022
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Oct 11, 2022
@AlekSi AlekSi marked this pull request as ready for review October 11, 2022 14:08
@AlekSi AlekSi requested a review from a team as a code owner October 11, 2022 14:08
@AlekSi AlekSi requested review from a team, chilagrow and noisersup and removed request for a team October 11, 2022 14:08
@AlekSi AlekSi mentioned this pull request Oct 11, 2022
Merged
7 tasks
@vercel vercel bot temporarily deployed to Preview October 11, 2022 14:11 Inactive
rumyantseva
rumyantseva requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions/concerns and asked for more docs (comments) in a couple of places.

cmd/ferretdb/main.go Show resolved Hide resolved
cmd/ferretdb/main.go Show resolved Hide resolved
cmd/ferretdb/main.go Show resolved Hide resolved
internal/util/state/state.go Show resolved Hide resolved
internal/util/state/state.go Outdated Show resolved Hide resolved
internal/util/state/state.go Show resolved Hide resolved
rumyantseva
rumyantseva previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview October 11, 2022 15:25 Inactive
rumyantseva
rumyantseva requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters fail.

@AlekSi AlekSi requested review from rumyantseva and a team October 11, 2022 16:39
@vercel vercel bot temporarily deployed to Preview October 11, 2022 16:40 Inactive
rumyantseva
rumyantseva approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi enabled auto-merge (squash) October 11, 2022 18:12
@vercel vercel bot temporarily deployed to Preview October 11, 2022 18:15 Inactive
@AlekSi AlekSi merged commit 470940b into FerretDB:main Oct 11, 2022
@AlekSi AlekSi deleted the uuid branch October 11, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlekSi @w84thesun @rumyantseva