New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplest validation to check data documents #1246
Add simplest validation to check data documents #1246
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
- Coverage 66.64% 66.37% -0.28%
==========================================
Files 269 270 +1
Lines 12574 12609 +35
==========================================
- Hits 8380 8369 -11
- Misses 3296 3331 +35
- Partials 898 909 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, except for those comments @AlekSi already provided.
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
…seva/FerretDB into issue-693-new-validation
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
Description
This PR closes #693.
In this solution we introduce
(d *Document) ValidateData() error
method to validate documents representing data.We use this method to solve what's needed in #693.
Tests are present in FerretDB/dance#211.
Tigris will be covered in the same Sprint in a separate task #1248 (to make
tigrisdb
similar topgdb
).Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.