Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fjson and fuzzing cleanup #1262

Merged
merged 13 commits into from Oct 17, 2022
Merged

fjson and fuzzing cleanup #1262

merged 13 commits into from Oct 17, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 14, 2022

Description

Remove some old code. Fix fuzztool.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 5:45AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 14, 2022 13:43 Inactive
@AlekSi AlekSi changed the title Test dump fjson and fuzzing cleanup Oct 14, 2022
@AlekSi AlekSi marked this pull request as ready for review October 14, 2022 13:44
@AlekSi AlekSi requested a review from a team as a code owner October 14, 2022 13:44
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 14, 2022
@AlekSi AlekSi added code/chore Code maintenance improvements do not merge PRs that should not be merged labels Oct 14, 2022
@AlekSi AlekSi self-assigned this Oct 14, 2022
@AlekSi AlekSi requested review from a team, chilagrow and noisersup and removed request for a team October 14, 2022 13:44
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #1262 (86f1b95) into main (68d11f7) will increase coverage by 0.34%.
The diff coverage is 95.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   66.34%   66.69%   +0.34%     
==========================================
  Files         270      270              
  Lines       12609    12614       +5     
==========================================
+ Hits         8366     8413      +47     
+ Misses       3336     3296      -40     
+ Partials      907      905       -2     
Impacted Files Coverage Δ
internal/bson/bson.go 43.33% <0.00%> (+43.33%) ⬆️
internal/bson/cstring.go 68.18% <ø> (ø)
internal/types/document.go 87.34% <ø> (ø)
internal/bson/document.go 44.96% <100.00%> (+0.93%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 87.52% <0.00%> (+0.94%) ⬆️
internal/types/fjson/fjson.go 89.39% <0.00%> (+3.03%) ⬆️
internal/handlers/pg/pgdb/settings.go 44.18% <0.00%> (+4.65%) ⬆️
internal/clientconn/conninfo/conn_info.go 83.33% <0.00%> (+16.66%) ⬆️
Flag Coverage Δ
integration 62.62% <75.00%> (+0.07%) ⬆️
mongodb 14.13% <40.00%> (-0.01%) ⬇️
pg 52.16% <75.00%> (+0.08%) ⬆️
tigris 33.75% <75.00%> (+0.04%) ⬆️
unit 25.12% <90.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi enabled auto-merge (squash) October 14, 2022 13:51
@vercel vercel bot temporarily deployed to Preview October 14, 2022 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview October 14, 2022 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview October 14, 2022 15:39 Inactive
@vercel vercel bot temporarily deployed to Preview October 14, 2022 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview October 16, 2022 11:31 Inactive
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Oct 17, 2022
@vercel vercel bot temporarily deployed to Preview October 17, 2022 05:45 Inactive
@chilagrow
Copy link
Contributor

Thanks for the docs!
@AlekSi Fuzz test CI is looking unhappy, doesn't seem like it's related to this PR though https://github.com/FerretDB/FerretDB/actions/runs/3262667842/jobs/5360097653

@AlekSi
Copy link
Member Author

AlekSi commented Oct 17, 2022

Yeah, it fails due to #364

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi
Copy link
Member Author

AlekSi commented Oct 17, 2022

Ok, "Fuzz short" is not required for PRs to be merged until we re-add validation and fix all fuzzing issues.

@AlekSi AlekSi merged commit b179486 into FerretDB:main Oct 17, 2022
@AlekSi AlekSi deleted the test-dump branch October 17, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants