Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for linking PRs and issues #1268

Merged
merged 8 commits into from Oct 19, 2022
Merged

Fix documentation for linking PRs and issues #1268

merged 8 commits into from Oct 19, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 17, 2022 •
edited

Description

For everyone in the team to review.

⚠️ I also disabled the project's workflow that sets the issue status to Done when it is closed. That should help us notice issues that are closed due to merged PR but are not done as a whole and should be reopened.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 4:47AM (UTC)

@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 17, 2022
@AlekSi AlekSi added the project Project maintenance label Oct 17, 2022
@AlekSi AlekSi self-assigned this Oct 17, 2022
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team October 17, 2022 17:08
@AlekSi AlekSi added the do not merge PRs that should not be merged label Oct 17, 2022
@AlekSi AlekSi enabled auto-merge (squash) October 17, 2022 17:09
@vercel vercel bot temporarily deployed to Preview October 17, 2022 17:09 Inactive
w84thesun
w84thesun previously approved these changes Oct 17, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 17, 2022 •
edited

Codecov Report

Merging #1268 (82a440a) into main (656055c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   67.12%   67.11%   -0.01%     
==========================================
  Files         270      270              
  Lines       12719    12719              
==========================================
- Hits         8537     8536       -1     
- Misses       3275     3276       +1     
  Partials      907      907
Impacted Files Coverage Δ
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (ø)
internal/clientconn/conninfo/conn_info.go 83.33% <0.00%> (+16.66%) ⬆️
Flag Coverage Δ
integration 63.00% <ø> (-0.03%) ⬇️
mongodb 14.08% <ø> (-0.03%) ⬇️
pg 52.41% <ø> (-0.03%) ⬇️
tigris 34.23% <ø> (-0.03%) ⬇️
unit 25.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 17, 2022 19:43 Inactive
chilagrow
chilagrow previously approved these changes Oct 18, 2022
View reviewed changes
rumyantseva
rumyantseva previously approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview October 18, 2022 09:04 Inactive
@AlekSi AlekSi requested review from a team and Fashander October 18, 2022 09:38
@AlekSi
Copy link
Member Author

AlekSi commented Oct 18, 2022

@Fashander PTAL

@AlekSi
Copy link
Member Author

AlekSi commented Oct 18, 2022

@noisersup PTAL

Fashander
Fashander requested changes Oct 18, 2022
View reviewed changes
.github/PROCESS.md Show resolved Hide resolved
.github/PROCESS.md Outdated Show resolved Hide resolved
@AlekSi AlekSi dismissed stale reviews from rumyantseva and chilagrow via f0bc184 October 18, 2022 12:04
AlekSi and others added 2 commits October 18, 2022 16:04
@AlekSi @Fashander
Update .github/PROCESS.md
f0bc184 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@AlekSi
Merge branch 'main' into linking-prs
8f2d077
@AlekSi AlekSi requested a review from Fashander October 18, 2022 12:04
@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:07 Inactive
@AlekSi AlekSi added do not merge PRs that should not be merged and removed do not merge PRs that should not be merged labels Oct 18, 2022
@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:42 Inactive
@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:52 Inactive
rumyantseva
rumyantseva approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fashander
Fashander approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview October 19, 2022 04:47 Inactive
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Oct 19, 2022
@AlekSi AlekSi merged commit 1c697c5 into FerretDB:main Oct 19, 2022
@AlekSi AlekSi deleted the linking-prs branch October 19, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@Fashander Fashander Fashander approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@AlekSi AlekSi

Labels
project Project maintenance
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlekSi @w84thesun @rumyantseva @chilagrow @Fashander