Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for the dummy handler #1276

Merged
merged 6 commits into from Oct 18, 2022
Merged

Update docs for the dummy handler #1276

merged 6 commits into from Oct 18, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 18, 2022

Description

Make it a bit easier to start a new handler.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 18, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 18, 2022
@AlekSi AlekSi self-assigned this Oct 18, 2022
@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 0:50AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 18, 2022 11:13 Inactive
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1276 (aea1376) into main (8a9a7af) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   67.10%   67.03%   -0.08%     
==========================================
  Files         270      270              
  Lines       12721    12719       -2     
==========================================
- Hits         8537     8526      -11     
- Misses       3277     3286       +9     
  Partials      907      907              
Impacted Files Coverage Δ
internal/handlers/dummy/dummy.go 0.00% <ø> (ø)
internal/handlers/tigris/msg_collmod.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_explain.go 0.00% <0.00%> (ø)
internal/handlers/tigris/tigris.go 86.95% <ø> (+6.95%) ⬆️
internal/handlers/pg/pgdb/settings.go 39.53% <0.00%> (-4.66%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/types/compare_order.go 80.95% <0.00%> (-2.39%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (ø)
Flag Coverage Δ
integration 62.94% <0.00%> (-0.08%) ⬇️
mongodb 14.08% <0.00%> (-0.04%) ⬇️
pg 52.35% <0.00%> (-0.08%) ⬇️
tigris 34.23% <0.00%> (-0.02%) ⬇️
unit 25.05% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 18, 2022 12:30
@AlekSi AlekSi requested a review from a team as a code owner October 18, 2022 12:30
@AlekSi AlekSi requested review from w84thesun, rumyantseva, a team, chilagrow, noisersup and Fashander and removed request for a team October 18, 2022 12:30
@AlekSi AlekSi enabled auto-merge (squash) October 18, 2022 12:30
@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:32 Inactive
@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:42 Inactive
@vercel vercel bot temporarily deployed to Preview October 18, 2022 12:50 Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 656055c into FerretDB:main Oct 18, 2022
@AlekSi AlekSi deleted the dummy branch October 18, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants