Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests cleanup #1287

Merged
merged 2 commits into from Oct 19, 2022
Merged

Improve tests cleanup #1287

merged 2 commits into from Oct 19, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 19, 2022

Description

That should make tests more stable.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 2:03PM (UTC)

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 19, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 19, 2022
@AlekSi AlekSi self-assigned this Oct 19, 2022
@vercel vercel bot temporarily deployed to Preview October 19, 2022 14:03 Inactive
@AlekSi AlekSi changed the title Leaking transactions Improve tests cleanup Oct 19, 2022
@AlekSi AlekSi marked this pull request as ready for review October 19, 2022 14:07
@AlekSi AlekSi requested a review from a team as a code owner October 19, 2022 14:07
@AlekSi AlekSi requested review from w84thesun, rumyantseva, a team, chilagrow and noisersup and removed request for a team October 19, 2022 14:07
@AlekSi AlekSi enabled auto-merge (squash) October 19, 2022 14:07
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1287 (df6bb13) into main (a51aa2d) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   67.16%   67.07%   -0.09%     
==========================================
  Files         270      271       +1     
  Lines       12722    12730       +8     
==========================================
- Hits         8545     8539       -6     
- Misses       3275     3284       +9     
- Partials      902      907       +5     
Impacted Files Coverage Δ
internal/util/testutil/testutil.go 100.00% <100.00%> (ø)
internal/util/testutil/testutil_unix.go 100.00% <100.00%> (ø)
internal/clientconn/conninfo/conn_info.go 66.66% <0.00%> (-16.67%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (-0.95%) ⬇️
Flag Coverage Δ
integration 62.99% <100.00%> (-0.08%) ⬇️
mongodb 14.13% <100.00%> (+0.03%) ⬆️
pg 52.41% <100.00%> (-0.07%) ⬇️
tigris 34.10% <100.00%> (+0.01%) ⬆️
unit 25.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit 645c0e8 into FerretDB:main Oct 19, 2022
@AlekSi AlekSi deleted the leaking-transactions branch October 19, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants