Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tjson into internal/handlers/tigris/tjson #1291

Merged
merged 4 commits into from Oct 21, 2022

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Oct 20, 2022

Description

Closes #1252.

We don't know how to deal with CVE-2022-3517 security issue, so we are skipping it in build/.trivyignore.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 7:48AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 20, 2022 10:04 Inactive
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1291 (d0e1a76) into main (7ca4464) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   67.33%   67.26%   -0.08%     
==========================================
  Files         275      275              
  Lines       12857    12857              
==========================================
- Hits         8657     8648       -9     
- Misses       3293     3302       +9     
  Partials      907      907              
Impacted Files Coverage Δ
internal/handlers/tigris/json_schema.go 84.21% <ø> (ø)
internal/handlers/tigris/msg_delete.go 68.35% <ø> (ø)
internal/handlers/tigris/tigrisdb/insert.go 42.85% <ø> (ø)
internal/handlers/tigris/tigrisdb/query.go 78.94% <ø> (ø)
internal/handlers/tigris/tigrisdb/update.go 45.45% <ø> (ø)
internal/handlers/tigris/tjson/binary.go 67.85% <ø> (ø)
internal/handlers/tigris/tjson/bool.go 59.09% <ø> (ø)
internal/handlers/tigris/tjson/datetime.go 56.00% <ø> (ø)
internal/handlers/tigris/tjson/document.go 44.70% <ø> (ø)
internal/handlers/tigris/tjson/double.go 59.09% <ø> (ø)
... and 12 more
Flag Coverage Δ
integration 62.81% <ø> (-0.08%) ⬇️
mongodb 14.16% <ø> (-0.03%) ⬇️
pg 52.32% <ø> (-0.08%) ⬇️
tigris 34.68% <ø> (-0.03%) ⬇️
unit 25.63% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow self-assigned this Oct 21, 2022
@chilagrow chilagrow added code/chore Code maintenance improvements code/tigris labels Oct 21, 2022
@vercel vercel bot temporarily deployed to Preview October 21, 2022 03:41 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 03:45 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 03:49 Inactive
@vercel vercel bot temporarily deployed to Preview October 21, 2022 07:48 Inactive
@chilagrow chilagrow requested review from a team, AlekSi, w84thesun, rumyantseva and noisersup and removed request for a team October 21, 2022 08:00
@chilagrow chilagrow marked this pull request as ready for review October 21, 2022 08:01
@chilagrow chilagrow requested a review from a team as a code owner October 21, 2022 08:01
@chilagrow chilagrow enabled auto-merge (squash) October 21, 2022 08:02
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 21, 2022
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 2555b09 into FerretDB:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tjson into internal/handlers/tigris/tjson
3 participants