Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-built textlint image #1366

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Use pre-built textlint image #1366

merged 1 commit into from
Nov 3, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 3, 2022

Description

That removes the need to rebuild it every time, removes node.js dependencies from the repo, etc.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

That removes the need to rebuild it every time, removes node.js dependencies from the repo, etc.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 3, 2022
@AlekSi AlekSi added this to the v0.6.1 milestone Nov 3, 2022
@AlekSi AlekSi self-assigned this Nov 3, 2022
@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 2:47PM (UTC)

@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team November 3, 2022 14:46
@AlekSi AlekSi enabled auto-merge (squash) November 3, 2022 14:47
@vercel vercel bot temporarily deployed to Preview November 3, 2022 14:47 Inactive
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1366 (71bb4df) into main (39f078f) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   67.22%   67.15%   -0.08%     
==========================================
  Files         279      279              
  Lines       13228    13228              
==========================================
- Hits         8893     8883      -10     
- Misses       3407     3415       +8     
- Partials      928      930       +2     
Impacted Files Coverage Δ
internal/handlers/tigris/tigrisdb/errors.go 50.00% <0.00%> (-22.23%) ⬇️
internal/handlers/tigris/tigrisdb/databases.go 66.66% <0.00%> (-7.70%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 86.74% <0.00%> (-0.63%) ⬇️
internal/handlers/pg/pgdb/settings.go 45.86% <0.00%> (+4.51%) ⬆️
Flag Coverage Δ
integration 63.23% <ø> (-0.08%) ⬇️
mongodb 14.17% <ø> (-0.03%) ⬇️
pg 52.40% <ø> (-0.03%) ⬇️
tigris 35.25% <ø> (-0.08%) ⬇️
unit 26.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge November 3, 2022 15:44
@AlekSi AlekSi merged commit f084e6a into FerretDB:main Nov 3, 2022
@AlekSi AlekSi deleted the textlint branch November 3, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants