Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing locks when update settings table #1381

Merged
merged 23 commits into from
Nov 14, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Nov 8, 2022

Description

Closes #1206.

Note: I didn't refactor how the settings table is used (as it's not in the scope of the task), I only fixed the exact problem with missing locks.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Nov 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 10:27AM (UTC)

@rumyantseva rumyantseva self-assigned this Nov 8, 2022
@rumyantseva rumyantseva added the code/enhancement Some user-visible feature could work better label Nov 8, 2022
@vercel vercel bot temporarily deployed to Preview November 8, 2022 11:04 Inactive
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1381 (7303e8f) into main (b4e281e) will increase coverage by 0.10%.
The diff coverage is 66.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1381      +/-   ##
==========================================
+ Coverage   67.26%   67.37%   +0.10%     
==========================================
  Files         279      279              
  Lines       13325    13353      +28     
==========================================
+ Hits         8963     8996      +33     
+ Misses       3432     3425       -7     
- Partials      930      932       +2     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/collections.go 50.00% <50.00%> (ø)
internal/handlers/pg/msg_listdatabases.go 66.99% <56.25%> (-0.41%) ⬇️
internal/handlers/tigris/tigrisdb/errors.go 53.57% <60.00%> (+1.39%) ⬆️
internal/handlers/pg/pgdb/settings.go 44.21% <63.63%> (-1.65%) ⬇️
integration/helpers.go 87.62% <100.00%> (+0.39%) ⬆️
internal/handlers/tigris/msg_create.go 74.64% <100.00%> (+8.97%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (ø)
... and 4 more
Flag Coverage Δ
integration 63.49% <66.17%> (+0.11%) ⬆️
mongodb 14.07% <7.35%> (-0.04%) ⬇️
pg 52.58% <54.41%> (+0.02%) ⬆️
tigris 35.34% <14.70%> (+0.03%) ⬆️
unit 26.06% <37.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 8, 2022 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 11:56 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 12:17 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 12:37 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 12:43 Inactive
@rumyantseva rumyantseva changed the title Fix the problem with settings table Add missing locks when update settings table Nov 8, 2022
@vercel vercel bot temporarily deployed to Preview November 8, 2022 12:59 Inactive
@rumyantseva rumyantseva marked this pull request as ready for review November 8, 2022 13:04
@rumyantseva rumyantseva requested a review from a team as a code owner November 8, 2022 13:04
@rumyantseva rumyantseva requested review from AlekSi, w84thesun, a team, chilagrow and noisersup and removed request for a team November 8, 2022 13:04
internal/handlers/pg/msg_listdatabases.go Outdated Show resolved Hide resolved
integration/create_test.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview November 9, 2022 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview November 9, 2022 17:44 Inactive
@vercel vercel bot temporarily deployed to Preview November 9, 2022 18:40 Inactive
@vercel vercel bot temporarily deployed to Preview November 9, 2022 18:45 Inactive
chilagrow
chilagrow previously approved these changes Nov 10, 2022
integration/create_test.go Outdated Show resolved Hide resolved
internal/handlers/pg/pgdb/settings.go Show resolved Hide resolved
rumyantseva and others added 2 commits November 10, 2022 10:46
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@vercel vercel bot temporarily deployed to Preview November 10, 2022 09:49 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 10:48 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 11:00 Inactive
@rumyantseva rumyantseva enabled auto-merge (squash) November 11, 2022 17:55
@vercel vercel bot temporarily deployed to Preview November 14, 2022 10:27 Inactive
@rumyantseva rumyantseva merged commit 2f6e1a7 into FerretDB:main Nov 14, 2022
@rumyantseva rumyantseva deleted the issue-1206-settings-table branch November 14, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the problem with settings table
5 participants