Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix information about delete's comment argument inside "supported commands" reference #1498

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Nov 17, 2022

Description

Small fix.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Nov 17, 2022

Deployment failed with the following error:

Resource is limited - try again in 2 hours (more than 100, code: "api-deployments-free-per-day").

@noisersup noisersup changed the title Fix information about delete's comment argument inside supported commands Fix information about delete's comment argument inside "supported commands" reference Nov 17, 2022
@noisersup noisersup self-assigned this Nov 17, 2022
@noisersup noisersup added the documentation Something user-visible is badly or not documented label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #1498 (46daaf7) into main (af2554a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   67.72%   67.72%           
=======================================
  Files         279      279           
  Lines       13492    13492           
=======================================
+ Hits         9137     9138    +1     
+ Misses       3431     3428    -3     
- Partials      924      926    +2     
Impacted Files Coverage Δ
internal/handlers/tigris/tigrisdb/databases.go 66.66% <0.00%> (-7.70%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (ø)
internal/handlers/tigris/tigrisdb/errors.go 42.85% <0.00%> (ø)
internal/handlers/tigris/tigrisdb/collections.go 60.00% <0.00%> (+5.71%) ⬆️
internal/handlers/tigris/msg_create.go 74.64% <0.00%> (+7.04%) ⬆️
Flag Coverage Δ
integration 63.80% <ø> (+<0.01%) ⬆️
mongodb 14.19% <ø> (-0.01%) ⬇️
pg 53.02% <ø> (-0.03%) ⬇️
tigris 36.10% <ø> (+<0.01%) ⬆️
unit 26.36% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review November 17, 2022 22:56
@noisersup noisersup requested review from a team, AlekSi, Fashander, w84thesun, rumyantseva and chilagrow and removed request for a team November 17, 2022 22:56
@AlekSi AlekSi added this to the v0.6.2 milestone Nov 18, 2022
@AlekSi AlekSi enabled auto-merge (squash) November 18, 2022 06:45
@AlekSi AlekSi merged commit 3e1a98c into FerretDB:main Nov 18, 2022
@noisersup noisersup deleted the supported-commands-fix branch November 18, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants