Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity values are not allowed in documents #1622

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Dec 5, 2022

Description

Closes #1581.

This PR fixes document validation restriction that was implemented but wasn't mentioned in diff.md docs.

See also FerretDB/dance#265.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the documentation Something user-visible is badly or not documented label Dec 5, 2022
@rumyantseva rumyantseva self-assigned this Dec 5, 2022
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 3:33PM (UTC)

@rumyantseva rumyantseva marked this pull request as ready for review December 5, 2022 15:23
@rumyantseva rumyantseva requested a review from a team December 5, 2022 15:23
@rumyantseva rumyantseva requested a review from a team as a code owner December 5, 2022 15:23
@vercel vercel bot temporarily deployed to Preview December 5, 2022 15:23 Inactive
@rumyantseva rumyantseva enabled auto-merge (squash) December 5, 2022 15:23
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup and removed request for a team December 5, 2022 15:23
@vercel vercel bot temporarily deployed to Preview December 5, 2022 15:26 Inactive
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1622 (a740c5e) into main (df54de4) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   68.10%   68.05%   -0.05%     
==========================================
  Files         285      285              
  Lines       13767    13766       -1     
==========================================
- Hits         9376     9369       -7     
- Misses       3452     3456       +4     
- Partials      939      941       +2     
Impacted Files Coverage Δ
internal/types/document_validation.go 100.00% <ø> (ø)
internal/util/version/version.go 70.58% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.68% <0.00%> (-0.55%) ⬇️
internal/handlers/pg/pgdb/insert.go 69.38% <0.00%> (+6.12%) ⬆️
Flag Coverage Δ
integration 64.02% <ø> (-0.05%) ⬇️
mongodb 14.00% <ø> (-0.03%) ⬇️
pg 52.90% <ø> (-0.05%) ⬇️
tigris 37.28% <ø> (-0.03%) ⬇️
unit 26.77% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

website/docs/diff.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview December 5, 2022 15:33 Inactive
@rumyantseva rumyantseva merged commit 8521c1e into FerretDB:main Dec 6, 2022
@rumyantseva rumyantseva deleted the infinity branch December 6, 2022 08:09
@AlekSi AlekSi added this to the v0.7.1 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify pjson format
4 participants