Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups #1786

Merged
merged 10 commits into from
Jan 12, 2023
Merged

Minor cleanups #1786

merged 10 commits into from
Jan 12, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 12, 2023 •
edited
Loading

Readiness checklist

  • I added unit tests for new functionality or bug fixes.
  • I added integration tests for new functionality or bug fixes.
  • I added compatibility tests for new functionality or bug fixes.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 12, 2023
@AlekSi AlekSi added this to the v0.8.1 milestone Jan 12, 2023
@AlekSi AlekSi self-assigned this Jan 12, 2023
@vercel
Copy link

vercel bot commented Jan 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 11:52AM (UTC)

@AlekSi AlekSi marked this pull request as ready for review January 12, 2023 04:28
@AlekSi AlekSi requested a review from a team January 12, 2023 04:28
@AlekSi AlekSi requested a review from a team as a code owner January 12, 2023 04:28
@AlekSi AlekSi requested review from Fashander, w84thesun, rumyantseva, chilagrow, a team and noisersup and removed request for a team January 12, 2023 04:28
@AlekSi AlekSi enabled auto-merge (squash) January 12, 2023 04:28
@vercel vercel bot temporarily deployed to Preview January 12, 2023 04:29 Inactive
@codecov
Copy link

codecov bot commented Jan 12, 2023 •
edited
Loading

Codecov Report

Merging #1786 (579a48e) into main (877215d) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
- Coverage   69.37%   69.15%   -0.23%     
==========================================
  Files         307      307              
  Lines       14602    14597       -5     
==========================================
- Hits        10130    10094      -36     
- Misses       3518     3547      +29     
- Partials      954      956       +2
Impacted Files Coverage Δ
internal/handlers/common/msg_listcommands.go 100.00% <100.00%> (ø)
internal/handlers/tigris/tigrisdb/errors.go 21.42% <0.00%> (-21.43%) ⬇️
internal/handlers/tigris/msg_create.go 67.60% <0.00%> (-7.05%) ⬇️
internal/handlers/tigris/tigrisdb/collections.go 61.90% <0.00%> (-4.77%) ⬇️
build/version/version.go 63.01% <0.00%> (-4.11%) ⬇️
internal/handlers/common/filter.go 85.20% <0.00%> (-1.48%) ⬇️
Flag Coverage Δ
integration 65.03% <100.00%> (-0.21%) ⬇️
mongodb 14.76% <0.00%> (+<0.01%) ⬆️
pg 53.66% <100.00%> (-0.13%) ⬇️
tigris 42.72% <100.00%> (-0.12%) ⬇️
unit 29.22% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Fashander
Fashander previously approved these changes Jan 12, 2023
View reviewed changes
chilagrow
chilagrow previously approved these changes Jan 12, 2023
View reviewed changes
@AlekSi AlekSi dismissed stale reviews from chilagrow and Fashander via 517ebb0 January 12, 2023 05:52
@vercel vercel bot temporarily deployed to Preview January 12, 2023 05:53 Inactive
@vercel vercel bot temporarily deployed to Preview January 12, 2023 06:10 Inactive
@AlekSi AlekSi requested review from chilagrow, Fashander, a team and b1ron January 12, 2023 06:14
chilagrow
chilagrow previously approved these changes Jan 12, 2023
View reviewed changes
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Jan 12, 2023
rumyantseva
rumyantseva previously approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, added a minor question about docs.

.github/workflows/conform-pr.yml Outdated Show resolved Hide resolved
.github/workflows/conform-pr.yml Outdated Show resolved Hide resolved
b1ron
b1ron suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@b1ron b1ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix.

website/docs/flags.md Outdated Show resolved Hide resolved
@AlekSi @b1ron
Update website/docs/flags.md
5e980e2 
Co-authored-by: b1ron <80292536+b1ron@users.noreply.github.com>
@AlekSi AlekSi dismissed stale reviews from rumyantseva and chilagrow via 5e980e2 January 12, 2023 11:50
AlekSi and others added 2 commits January 12, 2023 15:51
@AlekSi @rumyantseva
Update .github/workflows/conform-pr.yml
bc56a56 
Co-authored-by: Elena Grahovac <elena@grahovac.me>
@AlekSi @rumyantseva
Update .github/workflows/conform-pr.yml
579a48e 
Co-authored-by: Elena Grahovac <elena@grahovac.me>
@AlekSi AlekSi requested review from chilagrow, b1ron, rumyantseva and a team January 12, 2023 11:52
@vercel vercel bot temporarily deployed to Preview January 12, 2023 11:52 Inactive
@AlekSi AlekSi merged commit 167dcd1 into FerretDB:main Jan 12, 2023
@AlekSi AlekSi deleted the cleanup branch January 12, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@Fashander Fashander Fashander approved these changes

@b1ron b1ron b1ron approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlekSi @w84thesun @rumyantseva @chilagrow @Fashander @b1ron