Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement basic create command. #184

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Implement basic create command. #184

merged 4 commits into from
Dec 17, 2021

Conversation

ekalinin
Copy link
Contributor

@ekalinin ekalinin commented Dec 17, 2021 •
edited by AlekSi
Loading

Closes #150.

@ekalinin ekalinin changed the title Implement basic create command Implement basic create command Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #184 (a4bf717) into main (4d42878) will increase coverage by 0.84%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   45.13%   45.97%   +0.84%     
==========================================
  Files          87       88       +1     
  Lines        4354     4381      +27     
==========================================
+ Hits         1965     2014      +49     
+ Misses       2026     1997      -29     
- Partials      363      370       +7
Impacted Files Coverage Δ
internal/handlers/handler.go 53.88% <66.66%> (+4.44%) ⬆️
internal/handlers/shared/msg_create.go 77.77% <77.77%> (ø)
internal/handlers/common/errorcode_string.go 33.33% <0.00%> (+33.33%) ⬆️
internal/handlers/common/error.go 46.87% <0.00%> (+46.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d42878...a4bf717. Read the comment docs.

ekalinin and others added 2 commits December 17, 2021 19:35
@ekalinin
Some improvements in TestCreate
5540c4a
@ekalinin @AlekSi
Fix linter warnings
a4bf717 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi AlekSi self-requested a review December 17, 2021 16:43
@AlekSi AlekSi changed the title Implement basic create command Implement basic create command. Dec 17, 2021
AlekSi
AlekSi approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@AlekSi AlekSi merged commit b8de28b into FerretDB:main Dec 17, 2021
@ekalinin ekalinin deleted the create-command branch December 17, 2021 16:44
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Dec 21, 2021
@AlekSi AlekSi added this to the v0.0.5 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees
No one assigned
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.0.5
Development

Successfully merging this pull request may close these issues.

Support basic create command
2 participants
@ekalinin @AlekSi