Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushdown Tigris queries with dot notation #1908

Merged
merged 40 commits into from Feb 9, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Feb 1, 2023

Description

Closes #1841.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1908 (1b965e1) into main (31858ee) will increase coverage by 7.86%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
+ Coverage   62.06%   69.93%   +7.86%     
==========================================
  Files         316      316              
  Lines       15593    15604      +11     
==========================================
+ Hits         9678    10912    +1234     
+ Misses       5091     3739    -1352     
- Partials      824      953     +129     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/query.go 73.39% <100.00%> (-0.13%) ⬇️
internal/handlers/tigris/tigrisdb/query.go 83.33% <100.00%> (+33.33%) ⬆️
internal/util/ctxutil/ctxutil.go 80.95% <0.00%> (-9.53%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (ø)
internal/handlers/common/params.go 96.32% <0.00%> (+1.33%) ⬆️
internal/handlers/tigris/tjson/schema.go 81.52% <0.00%> (+1.63%) ⬆️
internal/handlers/tigris/tjson/tjson.go 78.33% <0.00%> (+2.77%) ⬆️
internal/handlers/tigris/tjson/document.go 46.98% <0.00%> (+3.61%) ⬆️
integration/setup/setup.go 80.98% <0.00%> (+4.22%) ⬆️
integration/shareddata/shareddata.go 88.65% <0.00%> (+6.18%) ⬆️
... and 42 more
Flag Coverage Δ
integration 66.11% <100.00%> (+11.36%) ⬆️
mongodb 14.24% <0.00%> (-0.03%) ⬇️
pg 54.58% <25.00%> (-0.06%) ⬇️
tigris 44.94% <75.00%> (?)
unit 29.09% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup self-assigned this Feb 8, 2023
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Feb 8, 2023
@noisersup noisersup marked this pull request as ready for review February 8, 2023 21:52
@noisersup noisersup requested a review from a team as a code owner February 8, 2023 21:52
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

internal/handlers/pg/pgdb/query_test.go Outdated Show resolved Hide resolved
internal/handlers/pg/pgdb/query_test.go Outdated Show resolved Hide resolved
@chilagrow
Copy link
Contributor

Conflict to resolve @noisersup 💪

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noisersup noisersup enabled auto-merge (squash) February 9, 2023 10:35
@w84thesun w84thesun changed the title Pushdown Tigris queries with dot notation Pushdown Tigris queries with dot notation Feb 9, 2023
@noisersup noisersup merged commit 8a41070 into FerretDB:main Feb 9, 2023
@noisersup noisersup deleted the pushdown-dotnotation-tigris-1841 branch February 9, 2023 10:40
@AlekSi AlekSi added this to the v0.9.1 milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushdown dot notation queries
4 participants