Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support projections #212

Merged
merged 17 commits into from
Jan 5, 2022
Merged

Support projections #212

merged 17 commits into from
Jan 5, 2022

Conversation

ekalinin
Copy link
Contributor

Fixes #80.

@codecov
Copy link

codecov bot commented Dec 28, 2021 •
edited

Codecov Report

Merging #212 (e0b5343) into main (c248ee5) will increase coverage by 0.42%.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   48.73%   49.16%   +0.42%     
==========================================
  Files          92       93       +1     
  Lines        4678     4711      +33     
==========================================
+ Hits         2280     2316      +36     
+ Misses       1985     1983       -2     
+ Partials      413      412       -1
Impacted Files Coverage Δ
internal/handlers/jsonb1/msg_find_or_count.go 67.22% <76.92%> (+1.43%) ⬆️
internal/handlers/jsonb1/projection.go 100.00% <100.00%> (ø)
internal/handlers/sql/msg_find_or_count.go 72.50% <100.00%> (+3.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c248ee5...e0b5343. Read the comment docs.

AlekSi
AlekSi reviewed Dec 28, 2021
View reviewed changes
internal/handlers/sql/msg_find_or_count.go Outdated Show resolved Hide resolved
internal/handlers/sql/msg_find_or_count.go Outdated Show resolved Hide resolved
internal/handlers/jsonb1/msg_find_or_count.go Outdated Show resolved Hide resolved
internal/handlers/jsonb1/msg_find_or_count.go Outdated Show resolved Hide resolved
ekalinin and others added 5 commits December 28, 2021 11:16
@ekalinin @AlekSi
Update internal/handlers/sql/msg_find_or_count.go
0bfb9a8 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@ekalinin @AlekSi
Update internal/handlers/sql/msg_find_or_count.go
a0b5a5a 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@ekalinin @AlekSi
Update internal/handlers/jsonb1/msg_find_or_count.go
2cb9bc0 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@ekalinin
Merge branch 'main' into projections-support
f81087d
@AlekSi
Merge branch 'main' into projections-support
e43638e
@AlekSi AlekSi self-requested a review December 28, 2021 10:01
@AlekSi AlekSi added this to the v0.0.6 milestone Jan 4, 2022
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Jan 4, 2022
@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet and removed code/enhancement Some user-visible feature could work better labels Jan 4, 2022
@AlekSi AlekSi changed the title Support projections. Support projections Jan 4, 2022
@AlekSi AlekSi mentioned this pull request Jan 5, 2022
Closed
@AlekSi AlekSi self-requested a review January 5, 2022 18:28
@AlekSi AlekSi enabled auto-merge (squash) January 5, 2022 18:32
@AlekSi
Copy link
Member

AlekSi commented Jan 5, 2022

Thank you!

@AlekSi AlekSi merged commit 83819cf into FerretDB:main Jan 5, 2022
@ekalinin ekalinin deleted the projections-support branch January 5, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees
No one assigned
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.0.6
Development

Successfully merging this pull request may close these issues.

Support projections
2 participants
@ekalinin @AlekSi