Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buildEnvironment and debug to buildInfo command #218

Merged
merged 16 commits into from
Jan 8, 2022
Merged

Add buildEnvironment and debug to buildInfo command #218

merged 16 commits into from
Jan 8, 2022

Conversation

gevorgyg
Copy link
Contributor

@gevorgyg gevorgyg commented Dec 28, 2021 •
edited by AlekSi

Closes #199.

@codecov
Copy link

codecov bot commented Dec 28, 2021 •
edited

Codecov Report

Merging #218 (722ab61) into main (60fc4fe) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   50.03%   49.98%   -0.06%     
==========================================
  Files         108      108              
  Lines        5054     5066      +12     
==========================================
+ Hits         2529     2532       +3     
- Misses       2128     2137       +9     
  Partials      397      397
Impacted Files Coverage Δ
internal/util/version/version.go 35.71% <10.00%> (-14.29%) ⬇️
internal/handlers/shared/msg_buildinfo.go 83.33% <100.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60fc4fe...722ab61. Read the comment docs.

@gevorgyg gevorgyg closed this Dec 30, 2021
@gevorgyg gevorgyg reopened this Dec 30, 2021
AlekSi
AlekSi reviewed Jan 4, 2022
View reviewed changes
internal/util/version/version.go Outdated Show resolved Hide resolved
internal/util/version/version.go Outdated Show resolved Hide resolved
internal/handlers/shared/msg_buildinfo.go Outdated Show resolved Hide resolved
internal/handlers/handler_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi added this to the v0.0.6 milestone Jan 4, 2022
@AlekSi AlekSi changed the title Add buildEnvironment and debug to buildInfo command #199 Add buildEnvironment and debug to buildInfo command Jan 4, 2022
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Jan 4, 2022
@gevorgyg gevorgyg requested a review from AlekSi January 7, 2022 23:21
AlekSi
AlekSi reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict that should be resolved

@AlekSi AlekSi self-requested a review January 8, 2022 06:51
@AlekSi
Copy link
Member

AlekSi commented Jan 8, 2022

Resolved :)

AlekSi
AlekSi reviewed Jan 8, 2022
View reviewed changes
internal/util/version/version.go Outdated
info.IsDebugBuild = true
}
case "-tags":
// TODO: replace for slices.Contains()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We totally could that now :)

Copy link
Contributor Author

@gevorgyg gevorgyg Jan 8, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just wasn't sure about getting golang.org/x/exp as a dependency only to use slices.Contains() in this place

@AlekSi AlekSi enabled auto-merge (squash) January 8, 2022 06:58
@AlekSi AlekSi merged commit 681f90a into FerretDB:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees
No one assigned
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Milestone
v0.0.6
Development

Successfully merging this pull request may close these issues.

Add buildEnvironment and debug to buildInfo command
2 participants
@gevorgyg @AlekSi