Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query pushdown documentation #2339

Merged
merged 23 commits into from Apr 12, 2023
Merged

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Mar 31, 2023

Description

Closes #1956.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2339 (d630394) into main (6934d0f) will decrease coverage by 37.40%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2339       +/-   ##
===========================================
- Coverage   64.27%   26.87%   -37.40%     
===========================================
  Files         392      392               
  Lines       19234    19234               
===========================================
- Hits        12362     5170     -7192     
- Misses       5969    13509     +7540     
+ Partials      903      555      -348     

see 125 files with indirect coverage changes

Flag Coverage Δ
integration 4.73% <ø> (-52.54%) ⬇️
mongodb 4.73% <ø> (?)
pg ?
unit 25.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup self-assigned this Apr 4, 2023
@noisersup noisersup added the documentation Something user-visible is badly or not documented label Apr 4, 2023
@noisersup noisersup marked this pull request as ready for review April 4, 2023 11:55
@noisersup noisersup added the do not merge PRs that should not be merged label Apr 4, 2023
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Apr 4, 2023
website/docs/pushdown.md Outdated Show resolved Hide resolved
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 4, 2023 13:08 — with GitHub Actions Inactive
@noisersup noisersup requested a review from AlekSi April 4, 2023 16:33
@noisersup noisersup temporarily deployed to cloudflare-dev April 4, 2023 16:33 — with GitHub Actions Inactive
website/docs/pushdown.md Outdated Show resolved Hide resolved
website/docs/pushdown.md Outdated Show resolved Hide resolved
website/docs/pushdown.md Outdated Show resolved Hide resolved
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 5, 2023 18:10 — with GitHub Actions Inactive
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@noisersup noisersup temporarily deployed to cloudflare-dev April 6, 2023 08:25 — with GitHub Actions Inactive
@noisersup noisersup temporarily deployed to cloudflare-dev April 11, 2023 19:14 — with GitHub Actions Inactive
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that in this PR we aim to keep things short and link a blog post for more details.

I added a couple of comments in the places that I find a bit unclear, but feel free to ignore them if everyone else is fine with the current definitions.

website/docs/pushdown.md Outdated Show resolved Hide resolved
website/docs/pushdown.md Outdated Show resolved Hide resolved
website/docs/pushdown.md Show resolved Hide resolved
chilagrow
chilagrow previously approved these changes Apr 12, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 12, 2023
@noisersup noisersup temporarily deployed to cloudflare-dev April 12, 2023 12:31 — with GitHub Actions Inactive
@noisersup noisersup temporarily deployed to cloudflare-dev April 12, 2023 13:07 — with GitHub Actions Inactive
@noisersup noisersup temporarily deployed to cloudflare-dev April 12, 2023 13:12 — with GitHub Actions Inactive
rumyantseva
rumyantseva previously approved these changes Apr 12, 2023
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

website/docs/pushdown.md Outdated Show resolved Hide resolved
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@noisersup noisersup temporarily deployed to cloudflare-dev April 12, 2023 17:44 — with GitHub Actions Inactive
@AlekSi AlekSi requested review from a team April 12, 2023 20:01
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rumyantseva rumyantseva temporarily deployed to cloudflare-dev April 12, 2023 22:31 — with GitHub Actions Inactive
@noisersup noisersup merged commit 85cc55f into FerretDB:main Apr 12, 2023
16 of 18 checks passed
@noisersup noisersup deleted the pushdown-docs-1956 branch April 12, 2023 23:02
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document query pushdown
5 participants