Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid short document keys like $k #234

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Forbid short document keys like $k #234

merged 1 commit into from
Jan 6, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 6, 2022

Closes #181.

@AlekSi AlekSi added the code/bug Some user-visible feature works incorrectly label Jan 6, 2022
@AlekSi AlekSi added this to the v0.0.6 milestone Jan 6, 2022
@AlekSi AlekSi enabled auto-merge (rebase) January 6, 2022 06:30
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #234 (c39fb58) into main (9ccdcd4) will increase coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   47.69%   48.26%   +0.57%     
==========================================
  Files         107      107              
  Lines        4982     4985       +3     
==========================================
+ Hits         2376     2406      +30     
+ Misses       2182     2164      -18     
+ Partials      424      415       -9     
Impacted Files Coverage Δ
internal/types/document.go 62.40% <100.00%> (+5.48%) ⬆️
internal/bson/document.go 43.36% <0.00%> (+2.91%) ⬆️
internal/wire/op_msg.go 45.85% <0.00%> (+2.92%) ⬆️
internal/wire/msg_body.go 36.50% <0.00%> (+4.76%) ⬆️
internal/bson/array.go 53.33% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccdcd4...c39fb58. Read the comment docs.

@AlekSi AlekSi disabled auto-merge January 6, 2022 07:10
@AlekSi AlekSi merged commit b8683f3 into main Jan 6, 2022
@AlekSi AlekSi deleted the dollar branch January 6, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid short document keys like $k
1 participant