Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark released binaries as dirty #2371

Merged
merged 2 commits into from Apr 5, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 5, 2023

Description

Closes #2368.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Apr 5, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 5, 2023
@AlekSi AlekSi self-assigned this Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2371 (41f8a82) into main (972391d) will decrease coverage by 36.94%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2371       +/-   ##
===========================================
- Coverage   63.99%   27.06%   -36.94%     
===========================================
  Files         391      391               
  Lines       18987    18987               
===========================================
- Hits        12151     5139     -7012     
- Misses       5929    13294     +7365     
+ Partials      907      554      -353     

see 125 files with indirect coverage changes

Flag Coverage Δ
integration 4.79% <ø> (-52.11%) ⬇️
mongodb 4.79% <ø> (ø)
pg ?
unit 25.71% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi removed trust PRs that can access Actions secrets packages PRs that should build packages labels Apr 5, 2023
@AlekSi AlekSi changed the title Do not mark binaries as dirty Do not mark released binaries as dirty Apr 5, 2023
@AlekSi AlekSi marked this pull request as ready for review April 5, 2023 09:47
@AlekSi AlekSi enabled auto-merge (squash) April 5, 2023 09:48
@AlekSi AlekSi merged commit c94b136 into FerretDB:main Apr 5, 2023
17 of 20 checks passed
@AlekSi AlekSi deleted the fix-version-extraction branch April 5, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version generation does not work correctly for git tags on CI
3 participants