Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to our documentation workflow #2390

Merged
merged 4 commits into from Apr 7, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 7, 2023

Description

Refs FerretDB/github-actions#160.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Apr 7, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 7, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements no ci labels Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #2390 (a786cbc) into main (e2e95e5) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2390      +/-   ##
==========================================
- Coverage   63.98%   63.93%   -0.05%     
==========================================
  Files         391      391              
  Lines       18987    18987              
==========================================
- Hits        12148    12139       -9     
- Misses       5931     5941      +10     
+ Partials      908      907       -1     

see 3 files with indirect coverage changes

Flag Coverage Δ
integration 56.87% <ø> (ø)
mongodb 4.79% <ø> (ø)
pg 56.80% <ø> (ø)
unit 25.71% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review April 7, 2023 15:00
@AlekSi AlekSi enabled auto-merge (squash) April 7, 2023 15:00
@AlekSi AlekSi removed the no ci label Apr 7, 2023
@AlekSi AlekSi requested review from a team, Fashander and ptrfarkas April 7, 2023 15:09
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Apr 7, 2023
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@w84thesun w84thesun temporarily deployed to cloudflare-dev April 7, 2023 16:01 — with GitHub Actions Inactive
@AlekSi AlekSi merged commit f9065d1 into FerretDB:main Apr 7, 2023
17 of 20 checks passed
@AlekSi AlekSi deleted the extract-url branch April 7, 2023 19:58
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 11, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants