Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types order linter #2391

Merged
merged 2 commits into from Apr 11, 2023
Merged

Fix types order linter #2391

merged 2 commits into from Apr 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 10, 2023

Description

Selector (package name) is ignored by that linter, so time.Time wasn't handled properly.

Closes #1630.
Closes #2092.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Apr 10, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 10, 2023
@AlekSi AlekSi requested a review from fenogentov April 10, 2023 11:10
@AlekSi AlekSi self-assigned this Apr 10, 2023
@AlekSi
Copy link
Member Author

AlekSi commented Apr 10, 2023

@fenogentov PTAL

@AlekSi AlekSi enabled auto-merge (squash) April 10, 2023 11:10
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #2391 (090386e) into main (f2027f1) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
+ Coverage   63.93%   63.99%   +0.06%     
==========================================
  Files         391      391              
  Lines       18987    18987              
==========================================
+ Hits        12139    12151      +12     
+ Misses       5941     5929      -12     
  Partials      907      907              

see 4 files with indirect coverage changes

Flag Coverage Δ
integration 56.89% <ø> (+0.01%) ⬆️
mongodb 4.79% <ø> (ø)
pg 56.81% <ø> (+0.01%) ⬆️
unit 25.88% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested a review from a team as a code owner April 10, 2023 13:36
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi merged commit 2549118 into FerretDB:main Apr 11, 2023
21 checks passed
@AlekSi AlekSi deleted the fix-linter branch April 11, 2023 10:27
@AlekSi AlekSi modified the milestones: v1.0.0 GA, v1.1.0 Apr 11, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 17, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
3 participants