Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecated errors #2411

Merged
merged 2 commits into from Apr 12, 2023
Merged

Conversation

chilagrow
Copy link
Contributor

@chilagrow chilagrow commented Apr 12, 2023

Description

While I'm looking at deprecated errors, I've moved them from common to commonerrors.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Apr 12, 2023
@chilagrow chilagrow self-assigned this Apr 12, 2023
@chilagrow chilagrow marked this pull request as ready for review April 12, 2023 07:59
@chilagrow chilagrow requested a review from a team as a code owner April 12, 2023 07:59
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2411 (d4a879e) into main (3530ddf) will decrease coverage by 37.14%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2411       +/-   ##
===========================================
- Coverage   63.98%   26.84%   -37.14%     
===========================================
  Files         391      391               
  Lines       18987    19144      +157     
===========================================
- Hits        12148     5139     -7009     
- Misses       5931    13451     +7520     
+ Partials      908      554      -354     
Impacted Files Coverage Δ
internal/clientconn/conn.go 0.00% <0.00%> (-45.72%) ⬇️
internal/handlers/common/distinct.go 0.00% <0.00%> (-60.76%) ⬇️
internal/handlers/common/filter.go 0.00% <0.00%> (-85.20%) ⬇️
internal/handlers/common/find.go 0.00% <0.00%> (-65.52%) ⬇️
internal/handlers/common/findandmodify.go 0.00% <0.00%> (-78.77%) ⬇️
internal/handlers/common/msg_debugerror.go 0.00% <0.00%> (ø)
internal/handlers/common/params.go 2.93% <0.00%> (-94.04%) ⬇️
internal/handlers/common/projection.go 0.00% <0.00%> (-31.90%) ⬇️
internal/handlers/common/saslstart.go 0.00% <0.00%> (-55.89%) ⬇️
internal/handlers/common/setfreemonitoring.go 0.00% <0.00%> (-60.87%) ⬇️
... and 27 more

... and 102 files with indirect coverage changes

Flag Coverage Δ
integration 4.75% <0.00%> (-52.13%) ⬇️
mongodb 4.75% <0.00%> (-0.04%) ⬇️
pg ?
unit 25.49% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v1.1.0 milestone Apr 12, 2023
@AlekSi AlekSi enabled auto-merge (squash) April 12, 2023 08:03
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'm glad we finally did it!

@AlekSi AlekSi merged commit 0eb2d8f into FerretDB:main Apr 12, 2023
18 of 23 checks passed
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 17, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi AlekSi changed the title Deprecated error cleanup Cleanup deprecated errors May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants