Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement projection fields assignment #2484

Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Apr 19, 2023

Description

Closes #2446.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/feature Some user-visible feature is not implemented yet label Apr 19, 2023
@w84thesun w84thesun self-assigned this Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #2484 (91e232b) into main (f0958a9) will increase coverage by 0.11%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
+ Coverage   64.54%   64.65%   +0.11%     
==========================================
  Files         397      397              
  Lines       19631    19643      +12     
==========================================
+ Hits        12670    12701      +31     
+ Misses       6045     6029      -16     
+ Partials      916      913       -3     
Impacted Files Coverage Δ
internal/handlers/common/projection.go 73.85% <93.33%> (+11.44%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 57.82% <93.33%> (+0.12%) ⬆️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg 57.75% <93.33%> (+0.12%) ⬆️
unit 25.24% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun marked this pull request as ready for review April 19, 2023 16:04
@w84thesun w84thesun requested a review from a team as a code owner April 19, 2023 16:04
@w84thesun w84thesun enabled auto-merge (squash) April 19, 2023 16:04
@w84thesun w84thesun requested review from a team, chilagrow and noisersup April 19, 2023 16:05
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment while looking at tests 🤗

integration/query_projection_compat_test.go Show resolved Hide resolved
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@w84thesun w84thesun merged commit 1479b0c into FerretDB:main Apr 20, 2023
21 checks passed
@w84thesun w84thesun deleted the issue-2446-projection-field-assignment branch April 20, 2023 11:03
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support field projections assignment
4 participants