Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle envtool panic on timeout #2499

Merged
merged 2 commits into from Apr 21, 2023
Merged

Handle envtool panic on timeout #2499

merged 2 commits into from Apr 21, 2023

Conversation

syasyayas
Copy link
Contributor

Description

Closes #2486.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@syasyayas syasyayas requested a review from a team as a code owner April 21, 2023 09:52
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@w84thesun w84thesun enabled auto-merge (squash) April 21, 2023 10:39
@w84thesun w84thesun added the code/chore Code maintenance improvements label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2499 (c200545) into main (1479b0c) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
- Coverage   64.68%   64.61%   -0.08%     
==========================================
  Files         397      397              
  Lines       19643    19643              
==========================================
- Hits        12707    12692      -15     
- Misses       6025     6039      +14     
- Partials      911      912       +1     

see 3 files with indirect coverage changes

Flag Coverage Δ
integration 57.82% <ø> (-0.04%) ⬇️
mongodb 5.05% <ø> (ø)
pg 57.75% <ø> (-0.04%) ⬇️
unit 25.27% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v1.1.0 milestone Apr 21, 2023
@AlekSi AlekSi changed the title Handle envtool panic on timeout Handle envtool panic on timeout Apr 21, 2023
@AlekSi
Copy link
Member

AlekSi commented Apr 21, 2023

@w84thesun PTAL

@w84thesun w84thesun merged commit b1cc4e8 into FerretDB:main Apr 21, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

envtool panics on timeout
4 participants