Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small addition to YAML formatter usage #2524

Merged

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Apr 27, 2023

Description

Closes #1301.

In this PR:

  • Change permissions only for linux.
  • Run yaml formatter as part of fmt task.
  • In this PR, I also run yaml formatter to format our current yaml files.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Apr 27, 2023
@rumyantseva rumyantseva self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #2524 (341d93f) into main (eaaa9b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2524   +/-   ##
=======================================
  Coverage   64.34%   64.34%           
=======================================
  Files         403      403           
  Lines       19954    19954           
=======================================
  Hits        12840    12840           
  Misses       6185     6185           
  Partials      929      929           

see 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.29% <ø> (ø)
mongodb 5.07% <ø> (ø)
pg 57.22% <ø> (ø)
unit 25.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review April 27, 2023 13:09
@rumyantseva rumyantseva requested review from a team and AlekSi as code owners April 27, 2023 13:09
@rumyantseva rumyantseva enabled auto-merge (squash) April 27, 2023 13:09
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rumyantseva rumyantseva merged commit f46ca4c into FerretDB:main Apr 28, 2023
26 checks passed
@rumyantseva rumyantseva deleted the issue-1301-yaml-formatter-next-step branch April 28, 2023 06:59
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use YAML formatter
4 participants