Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do various small cleanups #2561

Merged
merged 5 commits into from May 3, 2023
Merged

Do various small cleanups #2561

merged 5 commits into from May 3, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 3, 2023

Description

Refs #2236.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 3, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 3, 2023
@AlekSi AlekSi requested a review from a team May 3, 2023 05:06
@AlekSi AlekSi self-assigned this May 3, 2023
@AlekSi AlekSi requested a review from a team as a code owner May 3, 2023 05:06
@AlekSi AlekSi requested review from w84thesun and chilagrow May 3, 2023 05:06
@AlekSi AlekSi enabled auto-merge (squash) May 3, 2023 05:06
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup and removed request for a team May 3, 2023 05:06
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #2561 (5c38065) into main (30dd842) will increase coverage by 21.93%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #2561       +/-   ##
==========================================
+ Coverage   5.04%   26.97%   +21.93%     
==========================================
  Files        403      405        +2     
  Lines      19838    20086      +248     
==========================================
+ Hits        1000     5419     +4419     
+ Misses     18763    14095     -4668     
- Partials      75      572      +497     
Impacted Files Coverage Δ
internal/handlers/common/params.go 3.92% <0.00%> (+3.92%) ⬆️
internal/types/document.go 72.59% <ø> (+39.90%) ⬆️
internal/util/iterator/count.go 0.00% <ø> (ø)
internal/util/iterator/values.go 94.73% <ø> (+94.73%) ⬆️
internal/util/must/must.go 28.57% <0.00%> (-11.43%) ⬇️

... and 131 files with indirect coverage changes

Flag Coverage Δ
integration 5.03% <0.00%> (-0.01%) ⬇️
mongodb 5.03% <0.00%> (-0.01%) ⬇️
unit 25.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi merged commit 717f0fa into FerretDB:main May 3, 2023
22 of 23 checks passed
@AlekSi AlekSi deleted the minor-tweaks branch May 3, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants