Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logout command #2639

Merged
merged 12 commits into from May 29, 2023
Merged

Implement logout command #2639

merged 12 commits into from May 29, 2023

Conversation

kropidlowsky
Copy link
Contributor

Description

Closes #1750.

Implemented logout command.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@kropidlowsky kropidlowsky requested review from AlekSi, ptrfarkas and a team as code owners May 15, 2023 23:00
@codecov
Copy link

codecov bot commented May 15, 2023 •
edited

Codecov Report

Merging #2639 (7a9bae7) into main (0992e5f) will decrease coverage by 36.84%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2639       +/-   ##
===========================================
- Coverage   63.04%   26.20%   -36.84%     
===========================================
  Files         436      441        +5     
  Lines       22583    22602       +19     
===========================================
- Hits        14237     5923     -8314     
- Misses       7421    16073     +8652     
+ Partials      925      606      -319
Impacted Files Coverage Δ
internal/handlers/common/msg_logout.go 0.00% <0.00%> (ø)
...ternal/handlers/commoncommands/msg_listcommands.go 0.00% <ø> (-100.00%) ⬇️
internal/handlers/hana/msg_logout.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_logout.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_logout.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_logout.go 0.00% <0.00%> (ø)

... and 142 files with indirect coverage changes

Flag Coverage Δ
integration 4.97% <0.00%> (-51.53%) ⬇️
mongodb 4.97% <0.00%> (-0.01%) ⬇️
pg ?
unit 24.65% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi reviewed May 16, 2023
View reviewed changes
website/docs/reference/supported-commands.md Outdated Show resolved Hide resolved
internal/handlers/common/msg_logout.go Outdated Show resolved Hide resolved
integration/logout_test.go Outdated Show resolved Hide resolved
integration/logout_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi added this to the Next milestone May 16, 2023
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label May 16, 2023
@AlekSi AlekSi removed the request for review from w84thesun May 16, 2023 09:34
@kropidlowsky
Copy link
Contributor Author

@AlekSi Thank you for your review!

I have pushed the required changes.

@kropidlowsky kropidlowsky requested a review from AlekSi May 16, 2023 16:21
chilagrow
chilagrow reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thanks for the contribution!

I have a suggestion for expanding the logout test 🤗

integration/commands_authentication_test.go Outdated Show resolved Hide resolved
integration/commands_authentication_test.go Outdated Show resolved Hide resolved
integration/commands_authentication_test.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@kropidlowsky this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label May 18, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label May 18, 2023
@AlekSi AlekSi modified the milestones: v1.2.0, Next May 22, 2023
@kropidlowsky
Copy link
Contributor Author

Thank you for the review, @chilagrow.
I pushed required changes.
Could you please take look again? ✋

@chilagrow
Copy link
Contributor

👋 @kropidlowsky I'm not seeing your changes. Perhaps you forgot to push the change? 🤔

@kropidlowsky
Copy link
Contributor Author

@chilagrow, sorry! Now it is pushed. Please take a look again.

chilagrow
chilagrow approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, great test! Thanks for your contribution again 🤗

@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup May 25, 2023 00:04
@chilagrow chilagrow enabled auto-merge (squash) May 25, 2023 00:04
noisersup
noisersup approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

AlekSi
AlekSi approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chilagrow chilagrow merged commit 6a63df5 into FerretDB:main May 29, 2023
22 of 25 checks passed
@chilagrow chilagrow mentioned this pull request May 29, 2023
Merged
9 tasks
chilagrow added a commit that referenced this pull request May 29, 2023
@chilagrow
Add logout test for all backend (#2726)
ba0005b 
Closes #2639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow chilagrow approved these changes

@noisersup noisersup noisersup approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun was automatically assigned from FerretDB/core

Assignees

@kropidlowsky kropidlowsky

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Implement logout command
5 participants
@kropidlowsky @chilagrow @AlekSi @rumyantseva @noisersup