Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common commands to commoncommands #2660

Merged
merged 2 commits into from May 18, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented May 18, 2023

Description

Refs #2650.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label May 18, 2023
@AlekSi AlekSi added this to the Next milestone May 18, 2023
@AlekSi AlekSi self-assigned this May 18, 2023
@AlekSi AlekSi requested a review from a team as a code owner May 18, 2023 06:50
@AlekSi AlekSi enabled auto-merge (squash) May 18, 2023 06:50
@AlekSi AlekSi requested review from a team, chilagrow and noisersup May 18, 2023 06:50
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #2660 (9e508f5) into main (1c6136f) will increase coverage by 0.00%.
The diff coverage is 47.27%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2660   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files         429      428    -1     
  Lines       21293    21297    +4     
=======================================
+ Hits        13881    13885    +4     
  Misses       6477     6477           
  Partials      935      935           
Impacted Files Coverage Δ
...al/handlers/commoncommands/msg_connectionstatus.go 100.00% <ø> (ø)
internal/handlers/commoncommands/msg_currentop.go 100.00% <ø> (ø)
...rnal/handlers/commoncommands/msg_getcmdlineopts.go 0.00% <ø> (ø)
...ternal/handlers/commoncommands/msg_listcommands.go 100.00% <ø> (ø)
internal/handlers/commoncommands/msg_whatsmyuri.go 100.00% <ø> (ø)
internal/handlers/hana/msg_buildinfo.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_connectionstatus.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_currentop.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_debugerror.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_getcmdlineopts.go 0.00% <0.00%> (ø)
... and 32 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 58.25% <43.63%> (+<0.01%) ⬆️
mongodb 5.21% <0.00%> (-0.01%) ⬇️
pg 58.16% <43.63%> (+<0.01%) ⬆️
unit 26.19% <25.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 43be3d2 into FerretDB:main May 18, 2023
24 of 26 checks passed
@AlekSi AlekSi deleted the move-commands branch May 18, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants