Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use types.Null instead of nil #268

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Use types.Null instead of nil #268

merged 2 commits into from
Jan 16, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 16, 2022

Closes #216.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jan 16, 2022
@AlekSi AlekSi added this to the v0.0.6 milestone Jan 16, 2022
@AlekSi AlekSi enabled auto-merge (rebase) January 16, 2022 07:18
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #268 (fb6882a) into main (ba59015) will decrease coverage by 0.07%.
The diff coverage is 75.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   49.85%   49.78%   -0.08%     
==========================================
  Files         110      112       +2     
  Lines        5311     5323      +12     
==========================================
+ Hits         2648     2650       +2     
- Misses       2251     2260       +9     
- Partials      412      413       +1     
Impacted Files Coverage Δ
internal/bson/array.go 62.74% <ø> (ø)
internal/bson/bool.go 60.00% <ø> (ø)
internal/bson/bson.go 0.00% <0.00%> (ø)
internal/bson/cstring.go 68.18% <ø> (ø)
internal/bson/datetime.go 67.85% <ø> (ø)
internal/bson/double.go 70.83% <ø> (ø)
internal/bson/int32.go 68.18% <ø> (ø)
internal/bson/int64.go 68.18% <ø> (ø)
internal/bson/null.go 0.00% <0.00%> (ø)
internal/bson/objectid.go 65.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba59015...fb6882a. Read the comment docs.

@AlekSi AlekSi disabled auto-merge January 16, 2022 07:34
@AlekSi AlekSi enabled auto-merge (squash) January 16, 2022 07:34
@AlekSi AlekSi merged commit 4179962 into main Jan 16, 2022
@AlekSi AlekSi deleted the null branch January 16, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use separate value for NULL/nil
1 participant