Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use sjson.GetTypeOfValue where it shouldn't be used #2728

Merged
merged 2 commits into from
May 30, 2023

Merge branch 'main' into remove-gettypeofvalue

04b41c2
Select commit
Failed to load commit list.
Merged

Don't use sjson.GetTypeOfValue where it shouldn't be used #2728

Merge branch 'main' into remove-gettypeofvalue
04b41c2
Select commit
Failed to load commit list.
Codecov / codecov/project failed May 30, 2023 in 0s

26.19% (-36.85%) compared to 978278c

View this Pull Request on Codecov

26.19% (-36.85%) compared to 978278c

Details

Codecov Report

Merging #2728 (04b41c2) into main (978278c) will decrease coverage by 36.85%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2728       +/-   ##
===========================================
- Coverage   63.04%   26.19%   -36.85%     
===========================================
  Files         441      441               
  Lines       22619    22619               
===========================================
- Hits        14260     5926     -8334     
- Misses       7434    16087     +8653     
+ Partials      925      606      -319     
Impacted Files Coverage Δ
internal/handlers/commonparams/typecode.go 48.42% <ø> (-43.16%) ⬇️
internal/handlers/pg/msg_dropindexes.go 0.00% <0.00%> (-88.10%) ⬇️
internal/handlers/sjson/schema.go 83.78% <ø> (ø)

... and 143 files with indirect coverage changes