Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a few command stubs #2777

Merged
merged 3 commits into from Jun 2, 2023
Merged

Implement a few command stubs #2777

merged 3 commits into from Jun 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 2, 2023

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 2, 2023
@AlekSi AlekSi added this to the Next milestone Jun 2, 2023
@AlekSi AlekSi self-assigned this Jun 2, 2023
@AlekSi AlekSi marked this pull request as ready for review June 2, 2023 09:56
@AlekSi AlekSi requested a review from a team as a code owner June 2, 2023 09:56
@AlekSi AlekSi enabled auto-merge (squash) June 2, 2023 09:56
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup June 2, 2023 09:57
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2777 (e9785e1) into main (1d6997b) will decrease coverage by 36.97%.
The diff coverage is 1.35%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2777       +/-   ##
===========================================
- Coverage   63.01%   26.05%   -36.97%     
===========================================
  Files         441      441               
  Lines       22689    22727       +38     
===========================================
- Hits        14297     5921     -8376     
- Misses       7461    16195     +8734     
+ Partials      931      611      -320     
Impacted Files Coverage Δ
internal/handlers/pg/msg_explain.go 0.00% <0.00%> (-78.88%) ⬇️
internal/handlers/sqlite/cmd_query.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_createindexes.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_explain.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_hello.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_ismaster.go 0.00% <ø> (ø)
internal/util/testutil/path.go 69.84% <0.00%> (-23.81%) ⬇️
internal/util/testutil/db.go 87.30% <100.00%> (ø)

... and 142 files with indirect coverage changes

Flag Coverage Δ
integration 4.94% <1.35%> (-51.54%) ⬇️
mongodb 4.94% <1.35%> (-0.01%) ⬇️
pg ?
unit 24.52% <1.35%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge June 2, 2023 10:36
@AlekSi AlekSi changed the title Implements a few command stubs Implement a few command stubs Jun 2, 2023
@AlekSi AlekSi enabled auto-merge (squash) June 2, 2023 10:37
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 8c818a4 into FerretDB:main Jun 2, 2023
22 of 25 checks passed
@AlekSi AlekSi deleted the cleanup branch June 2, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants