Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testutil.Logger easier to use #2790

Merged
merged 1 commit into from Jun 5, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jun 5, 2023

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jun 5, 2023
@AlekSi AlekSi added this to the Next milestone Jun 5, 2023
@AlekSi AlekSi self-assigned this Jun 5, 2023
@AlekSi AlekSi marked this pull request as ready for review June 5, 2023 14:54
@AlekSi AlekSi requested a review from a team as a code owner June 5, 2023 14:54
@AlekSi AlekSi enabled auto-merge (squash) June 5, 2023 14:54
@AlekSi AlekSi requested review from a team, chilagrow and noisersup June 5, 2023 14:54
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2790 (bd8a276) into main (200c42a) will decrease coverage by 36.77%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2790       +/-   ##
===========================================
- Coverage   62.84%   26.07%   -36.77%     
===========================================
  Files         441      441               
  Lines       22737    22740        +3     
===========================================
- Hits        14288     5929     -8359     
- Misses       7517    16201     +8684     
+ Partials      932      610      -322     
Impacted Files Coverage Δ
integration/setup/setup_compat.go 9.28% <0.00%> (-67.15%) ⬇️
integration/setup/setup.go 62.08% <100.00%> (-1.10%) ⬇️
internal/util/testutil/testutil.go 100.00% <100.00%> (ø)

... and 142 files with indirect coverage changes

Flag Coverage Δ
integration 4.94% <62.50%> (-51.38%) ⬇️
mongodb 4.94% <62.50%> (+<0.01%) ⬆️
pg ?
unit 24.54% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested a review from noisersup June 5, 2023 15:11
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge June 5, 2023 15:18
@AlekSi AlekSi merged commit 2397140 into FerretDB:main Jun 5, 2023
25 of 30 checks passed
@AlekSi AlekSi deleted the tweak-logger-helper branch June 5, 2023 15:18
@rumyantseva
Copy link
Member

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants